Bug#879239: Acknowledgement (RFP: sigal -- Simple Static Gallery Generator)

[Antoine Beaupré <anarcat@debian.org>]

On Wed, Oct 25, 2017 at 03:00:29PM -0400, Antoine Beaupré wrote:
> Details on the dependencies...
> 
> Depends:
> 
>  * python3-markdown
>  * python3-blinker
>  * python3-click
>  * python3-jinja2
>  * python3-pilkit
>  * python3-pillow
>
> Recommends:
> 
>  * python3-feedgenerator (for RSS feed plugin)
>  * cssmin (or python3-cssmin?, to compress the CSS files in themes)
>  * python3-boto (to upload on s3)
>  * ffmpeg (for video conversion)

In case that wasn't clear: all those are present in Debian, although
pillow is packaged as python3-pil.

On Wed, Oct 25, 2017 at 05:08:09PM -0400, Antoine Beaupré wrote:
> Another issue I found: the pip package ships a copy of jquery and
> jquery-colorbox (which are in debian) and a bunch more javascript
> libraries: galleria, photoswipe, jquery-touchSwipe and leaflet (which
> are not). Even worse, one theme ships with jquery 1.11.1 while the other
> ships with 2.2.1. The jquery version shipped with Debian stretch is
> version 3.1.1-2, for the record.

This was fixed upstream, see this comment for details:

https://github.com/saimn/sigal/issues/200#issuecomment-370152691

> All of that JS is of course minified as well, so copies of those libs
> will need to be included somehow:
> 
> https://github.com/jquery/jquery/archive/2.2.1.tar.gz
> https://github.com/jquery/jquery/archive/1.11.1.tar.gz
> https://github.com/jackmoore/colorbox/archive/1.6.4.tar.gz
> https://github.com/worseisbetter/galleria/archive/1.4.2.tar.gz
> https://github.com/dimsemenov/PhotoSwipe/archive/v4.1.1.tar.gz
> https://github.com/mattbryson/TouchSwipe-Jquery-Plugin/archive/1.6.15.tar.gz
> https://github.com/Leaflet/Leaflet/archive/v0.7.3.tar.gz
> 
> Note that *all* of those (except colorbox) are out of date, for what
> that's worth.

That list is now:

 * galleria-1.5.7 (= latest: https://github.com/worseisbetter/galleria/releases)
   * jquery-3.3.1 (= latest: https://github.com/jquery/jquery/releases)
   * leaflet-0.7.3 (< 1.3.1: https://github.com/Leaflet/Leaflet/releases)
 * colorbox-1.6.4 (= latest: https://github.com/jackmoore/colorbox/releases)
   * jquery-2.2.1 (< 2.2.4: https://github.com/jquery/jquery/releases)
   * touchSwipe-1.6.18 (= latest: https://github.com/mattbryson/TouchSwipe-Jquery-Plugin/releases)
 * photoswipe 4.1.2 (= latest: https://github.com/dimsemenov/PhotoSwipe/releases)

> I'm not sure this can be resolved cleanly without duplicating code
> copies...

This issue remains, actually, because software like galleria and
colorbox do not use the latest upstream versions and have conflicting
versions with each other. But that's a packaging issue with those
javascript libraries, not with Sigal itself.

I'll open WNPP bugs for those three dependencies under the javascript
team umbrella and we'll see where that goes.