Bug#877388: s-nail adoption (build flags)

[Paride Legovini <pl@ninthfloor.org>]

Hi Hilko,

I've been working a little bit on the package, and it seems to me that
at the moment the Debian build flags (CFLAGS and LDFLAGS as set by the
debhelper scripts) are not actually used when building the package.

Note for example this error (happens during dh_auto_install):

ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
/bin/chown: changing ownership of
'/tmp/s-nail/debian/s-nail/usr/lib/s-nail/s-nail-privsep': Operation not
permitted
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.

and these lintian messages:

I: s-nail: hardening-no-fortify-functions usr/bin/s-nail
I: s-nail: hardening-no-fortify-functions usr/lib/s-nail/s-nail-privsep

W: s-nail-dbgsym: debug-file-with-no-debug-symbols
usr/lib/debug/.build-id/a7/0016ff0ddb7b0e70321b28e68f529204140f60.debug
W: s-nail-dbgsym: debug-file-with-no-debug-symbols
usr/lib/debug/.build-id/b0/3145705a4f0f2c7171bac4dc4b2c2ba23bb372.debug

Adding a couple of lines like:

export EXTRA_CFLAGS="$(CFLAGS)"
export EXTRA_LDFLAGS="$(LDFLAGS)"

in d/rules makes the debug-file-with-no-debug-symbols warning go away,
so I truly think the Debian CFLAGS and LDFLAGS were not used.
Unfortunately this seems not to be sufficient to fix the other issues,
something I would like to do even if s-nail works fine as is.

Now I don't want you to dig into this issue for me, but if you already
thought about it in the past and somehow concluded, for example, that
those errors/warning are both unavoidable and not harmful, I'd like to
hear from you.

Thanks again,

Paride