[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888985: [pkg-go] RFS: irtt/0.9-1 [ITP] (#888985)




On Feb 7, 2018, at 10:03 AM, Michael Stapelberg <stapelberg@debian.org> wrote:

Thanks for contributing this package.

Not at all, thank you kindly for patience with my complete newness to this!

The resulting binary package irtt_0.9-1_amd64.deb contains both a binary and Go source code. This is a bit unusual: in Debian, we only package Go source code to build other Go programs (not for developers). Hence, we usually provide either a binary package with programs or an arch:all package with Go source. It’s fine to have a source package which provides both, but please separate the source from the binaries. Have a look at https://anonscm.debian.org/cgit/collab-maint/codesearch.git/ for an example of this pattern.

Ah, ok. IRTT has an API, but it's not published yet. I think a binary-only package may be better at this point, and a separate source package later when that’s ready? If you agree, could you suggest a simple, current binary package hosted on github as a good example? Debian Code Search? Though its compat version is 8. I just liked how the debian directory is hosted right in the github repo, which brings me to another question...

Is it possible to maintain everything on github, or does it need to be on alioth, and if so, what is a good workflow for when I want to pull in changes from upstream for a new release?

Further, please address the following lintian warnings:

P: irtt source: package-uses-old-debhelper-compat-version 10
P: irtt source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
I: irtt source: out-of-date-standards-version 3.9.8 (released 2016-04-06) (current is 4.1.3)
I: irtt source: testsuite-autopkgtest-missing
W: irtt: priority-extra-is-replaced-by-priority-optional

You can run lintian like so:
% cat >> ~/.lintianrc <<'EOT'
display-info = yes
display-experimental = yes
pedantic = yes
show-overrides = no
color = auto
EOT
% lintian irtt_0.9-1_amd64.changes

Hrm, any idea why I'm seeing large differences in lintian output? I didn’t see any warnings before I posted, but I do see new ones after the .lintianrc changes, just they look completely different...

$ cat /etc/debian_version 
9.3
$ lintian --version
Lintian v2.5.50.4
$ cat .lintianrc 
display-info = yes
display-experimental = yes
pedantic = yes
show-overrides = no
color = auto
$ lintian ~/src/github.com/peteheist/irtt/dpkg/irtt_0.9-1_amd64.changes
P: irtt source: debian-watch-may-check-gpg-signature
I: irtt: hardening-no-fortify-functions usr/bin/irtt
I: irtt: spelling-error-in-binary usr/bin/irtt writeN written
I: irtt: spelling-error-in-binary usr/bin/irtt ot to
I: irtt: hardening-no-bindnow usr/bin/irtt
I: irtt: hardening-no-pie usr/bin/irtt
P: irtt: no-upstream-changelog

Also, some of the warnings (like compat-version) just come from output from dh-make-golang, which I just installed with ‘apt-get install dh-make-golang’. Do I need a newer version?

Let me know once this is done and I’ll be happy to take another look.

BTW, you don’t need to upload the package to mentors. I always work with the git repository directly.

Ok, that makes sense to me also- received that tip from a different Debian package admin. Thanks! :)


Reply to: