Hi Simon, On Wed, Dec 27, 2017 at 10:25:58AM +0100, Sébastien Villemot wrote: > On Tue, Dec 26, 2017 at 07:08:18PM -0600, Simon Quigley wrote: > > On 12/26/2017 02:21 AM, Sébastien Villemot wrote: > > > On Mon, Dec 25, 2017 at 08:23:55PM -0600, Simon Quigley wrote: > > > > > >> Tonight or tomorrow I'll get this ready for a review (I don't have > > >> upload access to Debian so I'll need someone to review/sponsor). > > > > > > Great! Just let me know when it’s ready, I’ll be happy to sponsor you. > > > > Should be good now, could you please check it over? > > Thanks. Actually there are a few issues: > > 1) I get the following lintian messages which signal problems in > debian/copyright: > > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/core/resource/bonus/flower_bad.png (paragraph at line 37) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/core/resource/bonus/flower_good.png (paragraph at line 37) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/core/resource/bonus/smiley_bad.png (paragraph at line 37) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/core/resource/bonus/smiley_good.png (paragraph at line 37) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/core/resource/bonus/tux_good.png (paragraph at line 45) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/core/resource/bonus/tux_bad.png (paragraph at line 45) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright src/activities/chess/resource/background.svg (paragraph at line 69) > I: gcompris-qt source: wildcard-matches-nothing-in-dep5-copyright gcompris.appdata.xml (paragraph at line 128) > I: gcompris-qt source: unused-file-paragraph-in-dep5-copyright paragraph at line 128 > I: gcompris-qt source: unused-file-paragraph-in-dep5-copyright paragraph at line 37 > I: gcompris-qt source: unused-file-paragraph-in-dep5-copyright paragraph at line 45 > I: gcompris-qt source: unused-file-paragraph-in-dep5-copyright paragraph at line 69 > > 2) The Vcs-Git and Vcs-Browser fields point to Ubuntu packaging, which is > probably not what you want. > > BTW, it looks like there are currently two git repositories on Alioth: one > in collab-maint (the most up-to-date) and one in pkg-kde-extras. I guess you > should decide which one to keep and delete the other one (and if you opt for > pkg-kde-extras, please finalize the changelog and add the debian git tag, > since I don't have write access to it). Any update on this? Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ http://www.debian.org
Attachment:
signature.asc
Description: PGP signature