Control: forcemerge -1 887012 Hi, I note that the description for this ITP is simply lifted from the git repo, and that it isn't appropriate for a Debian package's description, which combination seems to be a bit of a red flag on these ITPs. The "longer" description is simply untrue -- the code does not in fact run rm -rf. Instead it is a rather poor attempt at a re-implementation, judging by this: https://github.com/mrDarcyMurphy/node-rmrf/issues/4 which strikes me as an RC bug. The fix for that bug has been untouched for over two years: https://github.com/mrDarcyMurphy/node-rmrf/pull/5 which also have addressed the fact that the existing code cannot deal with deleting special files, instead attempting to recurse into them on the assumption that anything that's not a file must be a directory. :-/ The last commit here was in 2013 -- which suggests that this is dead upstream (unless there's an active repository elsewhere). Is this really the best implementation of a recursive delete in the node ecosystem? If there is something better, would it not be wise to drop this as a dependency and use the better thing instead, hopefully pushing that change upstream and so reducing reliance on this faulty implementation? This doesn't give me the impression of something that's worth packaging, unless you're planning on becoming the upstream, and fixing it first. Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/ http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY
Attachment:
signature.asc
Description: PGP signature