On Sep 22, 2017, at 09:28, Pierre-Elliott Bécue <becue@crans.org> wrote: >> >>> In d/tests/mailman3-core-tests, what do you think about using `python3 -m nose2` instead of `nose2-3`? >> >> As I wasn't able to have working tests for this package, they're disabled in >> d/rules. Maybe I just should remove this file. Can you remember why the test suite doesn’t work in d/rules? I do think that if they can’t be run in d/rules, they should be run at some point, and autopkgtests are a good alternative. While that doesn’t block promotion in Debian (yet?) it does in Ubuntu, so there should be good feedback when the autopkgtests fail. That said, in my own packages I always try to include a few other autopkgtests. Things like: * Run the command line (e.g. ``mailman —help``) * Try to create a simple list * Do a simple ``mailman shell`` command * Hit the REST API and just make sure it returns some non-error. >> Another interesting integration test might be to start up MM3’s REST API and GET the /3.1/system/versions resource, then either print the JSON or compare its value to something expected. It’s at least a minimal sniff test that some runners could be started up. >> >> I think this requires more background on mailman3 functionnalities that I >> currently have. Maybe I'll set this suggestion in debian/TODO for later! +1! Tests are an investment over time, so just get the bare minimum working now, and it can always be improved. >> autopkgtest fails for me with: >>> >>> After this operation, 159 MB of additional disk space will be used. >>> Err:1 http://httpredir.debian.org/debian sid/main amd64 python3-falcon amd64 1.0.0-2+b1 >>> 404 Not Found >>> E: Failed to fetch http://httpredir.debian.org/debian/pool/main/p/python-falcon/python3-falcon_1.0.0-2+b1_amd64.deb 404 Not Found >>> E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? >>> autopkgtest [20:07:28]: ERROR: testbed failure: apt repeatedly failed to download packages >> >> I guess I'm not able to do such test myself. You should be able to build the source package, and then if you have a chroot, just do: $ autopkgtest mailman-core-blah-blah.dsc — schroot sid-amd64 Cheers, -Barry
Attachment:
signature.asc
Description: Message signed with OpenPGP