Bug#870906: ITP: pynmea2 - pynmea2 is a python library for the NMEA 0183 protocol
Hi Joachim Langenbach,
> Hi Herbert,
>
> thanks for your hints. Hopefully this time, I got all of them ;-) I have some
> questions related to some of your hints:
>
>> There are some adjusts to do:
>>
>> debian/compat:
>>
>> - instead of '9' put '10' (number only)
>>
>> debian/control:
>>
>> - Build-Depends entry: python3-all-dev can be removed.
>> 'cowbuilder' builds the package without it.
>> - lintian needs an update. You can put '4.1.0'.
>
> I only found 4.0.1 (at https://www.debian.org/doc/debian-policy/upgrading-checklist.html). Are there any other sources to find the most recent standards
> version? However, I used 4.1.0 in my new upload.
q>
>> - Testsuite can be removed. There is no 'debian/tests' dir.
>
> I added the testsuite, because it should run the python tests included in
> pynmea2 sources. Did I understand testsuite the wrong way here? (Removed it in
> my upload)
The upstream is not using unittest, so this happens:
dh_auto_test -O--buildsystem=pybuild
I: pybuild base:184: cd /home/qemu/sponsor/pynmea2-1.9.0/.pybuild/pythonX.Y_3.6/build; python3.6 -m unittest discover -v
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
I: pybuild base:184: cd /home/qemu/sponsor/pynmea2-1.9.0/.pybuild/pythonX.Y_3.5/build; python3.5 -m unittest discover -v
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
As the upstream is using pytest it is necessary to put in debian/rules:
export PYBUILD_TEST_PYTEST = 1
Then we have:
dh_auto_test -O--buildsystem=pybuild
I: pybuild base:184: cd /home/qemu/sponsor/pynmea2-1.9.0/.pybuild/pythonX.Y_3.6/build; python3.6 -m pytest test
============================= test session starts ==============================
platform linux -- Python 3.6.2, pytest-3.2.1, py-1.4.34, pluggy-0.4.0
rootdir: /home/qemu/sponsor/pynmea2-1.9.0, inifile:
collected 54 items
test/test_file.py .
test/test_proprietary.py ..............
test/test_pynmea.py ..................
test/test_stream.py .....
test/test_types.py ................
========================== 54 passed in 0.36 seconds ===========================
I: pybuild base:184: cd /home/qemu/sponsor/pynmea2-1.9.0/.pybuild/pythonX.Y_3.5/build; python3.5 -m pytest test
============================= test session starts ==============================
platform linux -- Python 3.5.4, pytest-3.2.1, py-1.4.34, pluggy-0.4.0
rootdir: /home/qemu/sponsor/pynmea2-1.9.0, inifile:
collected 54 items
test/test_file.py .
test/test_proprietary.py ..............
test/test_pynmea.py ..................
test/test_stream.py .....
test/test_types.py ................
========================== 54 passed in 0.36 seconds ===========================
I think this is the last fix. :)
Regards,
Herbert
>
> Regards,
>
> Joachim
>
>> - Architecture: should be 'all'. (any is for programs like C, C++)
>> - Depends entry: '${shlibs:Depends}' can be removed.
>> - Provides entry can be removed.
>>
>> debian/copyright:
>>
>> - Debian entry is missing. The file should look like this:
>>
>> Files: *
>> Copyright: (C) 2013-2017 Tom Flanagan <tom@zkpq.ca>
>> License: MIT
>>
>> Files: debian/*
>> Copyright: 2017 Your-name-here <email@here.something>||
>> License: Choose-one (usually upstream choice)
>>
>> License: MIT
>> Permission is hereby granted, free of charge, to any person obtaining
>> blababla
>>
>> License: (If you choose something different add here)
>> blablabla
>> a copy of this software and associated documentation files
>>
>>
>> debian/rules:
>>
>> - I said about cleaning SOÛRCES.txt. You did right. But
>> I learned something that looks better. Instead of an
>> override_dh_auto_clean, 'egg-info' can be ignored if
>> we use 'debian/source/options' file. One line in the
>> file:
>> |
>>
>> extend-diff-ignore="^[^/]+\.egg-info/"
>>
>> |
>>
>> Just in case, please see:
>>
>> https://anonscm.debian.org/cgit/debian-science/packages/python-meshio.git/t
>> ree/debian/source/options
>>
>>
>> That's it. Let me know when you when the package
>> is ready.
>>
>>
>>
>> regards,
>> Herbert
>
Reply to: