[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#822246: ITP: qt5ct -- Qt5 configuration tool



Hi again,

With some experimentation, I replaced the contents of
/etc/X11/Xsession.d/99qt5ct with the following:

# Enable qt5ct by default unless another PLATFORMTHEME option is set
# or KDE is running.
if [ -z "$QT_QPA_PLATFORMTHEME" ] && [ "$XDG_CURRENT_DESKTOP" != "KDE" ]
then
        export QT_QPA_PLATFORMTHEME=qt5ct
fi

This seemed to work: the end result is that qt5ct is enabled on Xfce,
GNOME and Budgie, but not enabled on Plasma 5. I also went ahead and
removed the QT_PLATFORMTHEME and QT_PLATFORM_PLUGIN defines because they
aren't necessary based on the upstream readme and my own testing.

A git-style patch with this change is attached.

Best,
James

On 01/09/17 07:31 AM, Lisandro Damián Nicanor Pérez Meyer wrote:
> On 27 August 2017 at 17:03, James Lu <bitflip3@gmail.com> wrote:
>> Hi everyone,
>>
>> From what I read at
>> https://forum.antergos.com/topic/6487/qt5ct-has-priority-over-standard-plasma-settings-app/2,
>> Lisandro's concerns are correct and qt5ct does appear to override
>> Plasma's settings entirely. However, since qt5ct requires an Xsession
>> file[1] to be enabled by default, could one solution be having the
>> script exit silently if it finds any KDE environment variables? (This is
>> assuming that the order at which vars are set make this possible, but I
>> haven't verified that)
> 
> This is definitely something to try, yes.
> 
>> Alternatively, would it make sense for qt5ct to Break or Conflict with
>> Plasma, at least until these issues are worked around?
> 
> And a nice way around it in case the above fails.
> 
> If you are interested in trying this I'll be more than happy to sponsor you.
> 
> Dmitry/team: any comments from you?
> 
> 
From d0738c2146e02a5dd553f1d96ba37b506f6e8727 Mon Sep 17 00:00:00 2001
From: James Lu <james@overdrivenetworks.com>
Date: Sat, 2 Sep 2017 01:29:41 -0700
Subject: [PATCH] Don't enable qt5ct on KDE, or when another platform theme is
 set

---
 debian/99qt5ct | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/debian/99qt5ct b/debian/99qt5ct
index 0362b72..32d7105 100644
--- a/debian/99qt5ct
+++ b/debian/99qt5ct
@@ -1,3 +1,6 @@
-export QT_QPA_PLATFORMTHEME=qt5ct
-export QT_PLATFORMTHEME=qt5ct
-export QT_PLATFORM_PLUGIN=qt5ct
+# Enable qt5ct by default unless another PLATFORMTHEME option is set
+# or KDE is running.
+if [ -z "$QT_QPA_PLATFORMTHEME" ] && [ "$XDG_CURRENT_DESKTOP" != "KDE" ]
+then
+        export QT_QPA_PLATFORMTHEME=qt5ct
+fi
-- 
2.14.1

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: