Bug#824670: ITP: dnsdiag -- DNS Diagnostics and Performance Measurement Tools
Hi Antoine,
Many thanks for the review, it is greatly appreciated.
> (1) The package description could be improved... Use more spaces between
> paragraphs.
Done.
> (2) Also, I would remove the series of questions on the first lines of
> the description. We are aiming at more neutral description of what the
> package does, not an advertisement. :)
Removed the questions and reworded the description slightly.
> (3) The Vcs-Git line is incorrect - it needs to be a proper git URL:
> I suggest you use collab-maint as it is easy to get access to it. If you
> already have access to the pkg-netmeasure group, that's fine too, but be
> sure to push your changes there.
Usually I go on alioth to create and push the repo after everything has
been reviewed, so yes, it does not exist yet.
Have recently gained access to collab-maint, will push there.
> (4) Why do you use a `.install` file instead of letting the regular
> setup.py install targets do their thing?
This needs to be forwarded upstream I think, there is a problem with
setup.py. Without the install file we get an empty package. You can try
to do find_packages() to see python does not find any, or take out the
install file and build the package to reproduce the issue. I've changed
the solution slightly by now installing the scripts directly in /usr/bin
and renaming them, and patched out the entry_points in setup.py.
> (5) in the patches, I recommend you follow the patch tagging guidelines
> documented here:
>
> http://dep.debian.net/deps/dep3/
>
> for example, i'd be curious to hear why the cmrywhois patch is required
> or what the "test.diff" patch actually does (or why it's called
> "test"!)...
I deleted test.diff with quilt but it must have ended up in a commit. It
was a sorry attempt at fixing setup.py, the file is gone now. Have added
more info in the header for the cymruwhois patch, let me know if that
looks ok.
> (6) the watch file is a bit odd - there's a commented out line, but then
> it still kind of works because the next line kicks in... it confuses the
> mentors site as well, so you probably want to clean that up.
Done, removed the comment.
> Unfortunately, it is too late to make it
> into stretch, and that's my fault, but we will be able to backport this
> fairly easily I believe...
Thank you again for your feedback, I found it to be very constructive.
Have reuploaded on mentors and pushed to collab-maint.
Regards,
Ana
Reply to: