Le mercredi 20 septembre 2017 à 18:53:50+0200, Jonas Meurer a écrit : > Hey PEB, hey Barry, > > > Am 07.09.2017 um 12:55 schrieb Jonas Meurer: > > Am 07.09.2017 um 12:37 schrieb Pierre-Elliott Bécue: > >> I have some news. > >> > >> Mattia (mapreri on IRC) gave me a first review of my package>> with plenty small fixes to apply. I didn't have time until > >> now because of some deadlines in my PhD work. > > Hope that your PhD work is going well. > > >> I'll jump back in at the end of the week. > >> > >> Barry was in the middle of a rush AFAIR, and for now I got little news. > > > > that's great to hear. I'll wait for your fixes and give the packages > > another try afterwards. Just drop me a note and I'll do further review. > > I found some time to work on mailman3-core and mailmanclient packages > during the last days. You find the latest packaging status in the repos at > > https://github.com/P-EB/mailman3-core > https://anonscm.debian.org/cgit/python-modules/packages/mailmanclient.git/ > > In my eyes the mailman3-core and mailmanclient packages are in shape for > getting uploaded by now (hyperkitty & postorius still need some love). > > @barry: I could do the uploads but as you're PEB's sponsor so far you > might want to do that yourself. Maybe you also want to review the latest > changes to the packages? That would be awesome. > > In any case, let me know what procedure you prefer. I'll wait for PEB's > and your feedback before any further steps. Hey, I dived in your changes. For d/README.source, I changed the build method to put sbuild, as I never worked out a proper solution to build with gbp, and as sbuild fits properly for my needs. You can edit the file again if you wish, but in that case I'd need some hints on what is going wrong on my server. ^^ Your changes induced some lintian warnings, I can take the time to fix them, but maybe you'd be more efficient to do so. C/P of the lintian warnings: W: mailman3-core-doc: privacy-breach-generic usr/share/doc/mailman3-core-doc/html/README.html (https://gitlab.com/mailman/mailman/badges/master/build.svg) N: N: This package creates a potential privacy breach by fetching data from an N: external website at runtime. Please remove these scripts or external N: HTML resources. N: N: Please replace any scripts, images, or other remote resources with N: non-remote resources. It is preferable to replace them with text and N: links but local copies of the remote resources are also acceptable as N: long as they don't also make calls to remote services. Please ensure N: that the remote resources are suitable for Debian main before making N: local copies of them. N: N: Severity: important, Certainty: wild-guess N: N: Check: files, Type: binary, udeb N: W: mailman3-core-doc: privacy-breach-generic usr/share/doc/mailman3-core-doc/html/README.html (https://readthedocs.org/projects/mailman/badge) W: mailman3-core-doc: privacy-breach-generic usr/share/doc/mailman3-core-doc/html/README.html (http://img.shields.io/pypi/v/mailman.svg) W: mailman3-core-doc: privacy-breach-generic usr/share/doc/mailman3-core-doc/html/README.html (http://img.shields.io/pypi/dm/mailman.svg) In the documentation package, your changes reintroduced the many layers of directories before the documentation files, e.g. ./usr/share/doc/mailman3-core-doc/html/src/mailman/commands/docs/withlist.html I had found a way to remove the src/mailman that is useless. Is there a way to keep the .rst files as you did and mangle a bit the paths? Otherwise, I still have to implement some suggestions of Mattia. In particular the ones regarding the owner/group of the installed files, he suggests we use a postinst script to set the owner appropriately. -- PEB
Attachment:
signature.asc
Description: PGP signature