[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#817779: Dask & Toolz



On Fri, 2016-12-02 at 16:17 -0800, Stefan van der Walt wrote:
> I packaged toolz and pushed it to mentors, but no one picked it up.

Yes, I'm not sure who watches mentors. It's certainly a good idea to
mention the package is there to potential mentors. When I was learning
I found it easiest to work directly with a team. That way I'd have a
ready mentor to review the package.

(I personally liked working through IRC more than the mailing lists,
though different teams prefer different methods of communication)

> My attempt is here: https://github.com/stefanv/toolz/tree/debian

I looked through your packaging, it seems reasonable. Minor issues:

You probably should add a license for the debian/* files in the
d/copyright. (It's usually easiest if you use the same license as the
package, but if you want to use one of the another license that's
compatible with upstreams license that's fine.)

I'm don't think the PYVER and PY3VERS stuff in d/rules is still needed
with more recent versions of pybuild. PYVERs is certainly not needed
since you're not building python 2.

I didn't see the sphinx docs, that's a good point and should be
included.

I wonder if we're still supposed to be providing python2 packages, I'll
ask on #debian-python. And the answer is we only need python 3, if
someone asks then we can add python 2.

I think your control file should include the github home page. I think
there's a preference to use pypi for d/watch instead of github, though
that can be debated.

Have you run lintian on the source & binaries?

I was encouraged to use:
lintian -Ii --pedantic --color auto
and evaluate the results.

Can you list a branch in the vcs-git tag in d/control?

There's also a new release of dask, though it unfortunately has more
dependencies. (If you'd be interested we could split them up to try and
get them all packaged).

I'd be more than happy to sponsor your toolz package if you made some
of the changes suggested above. (Especially adding the debian/* license
block)

I feel like it'd be best to put the package in the debian python
modules team. They have their opinions about how to organize the
repository.
https://wiki.debian.org/Python/GitPackaging

What do you think of listing
Maintainer: Debian Python Modules Team <python-modules-team@lists.aliot
h.debian.org>
Uploaders: <you>


> I would be happy if you could take this further.  Are you also
> planning
> on packaging Dask and Distributed?

Do you have any packaging for those?

I'd like to see them in Debian, and am willing to work on it if no one
else is. However there was a lot of work associated with getting all of
the continuum analytics stuff into Debian.

I had been trying to build bokeh, and at one point the unit tests were
using blaze which had an overwhelming number of dependencies.

If you have more python data science packages, feel free to contact me
directly to review them. (I'm at Caltech in a bioinformatics lab that's
heavily using python and jupyter and other related tools).

Diane


Reply to: