[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847749: ITP: node-user-home -- Get the path to the user home directory



On 12/11/2016 07:57 PM, Sruthi Chandran wrote:
> On 12/12/2016 12:20 AM, Sruthi Chandran wrote:
>> On 12/11/2016 11:30 PM, Christian Seiler wrote:
>>>> I've attached an updated use-os-homedir.patch that does this (including
>>>> the removal of the require.resolve() line above),
>> Thanks a lot!!! That fixed it.
> It was fixed in local build, but fails in sbuild. Can you check?

I see you enabled the tests during build; the problem here is that
the tests write to the home directory, which is not allowed during
package build (see a recent thread on debian-devel about that),
and sbuild enforces that by setting the home directory of the
sbuild user to something like /non-existent.

You can manually set the HOME environment variable during testing
to override that with a temporarily created directory.

I've attached a git patch against your current packaging (you can
use git am to apply it) that does just this. I've tried building
it in sbuild -d unstable and it works - and the tests pass.

Hope that helps.

Regards,
Christian
From 20e34e4f7ab4ed42574460ce771dc6d76d8395b2 Mon Sep 17 00:00:00 2001
From: Christian Seiler <christian@iwakd.de>
Date: Sun, 11 Dec 2016 20:01:59 +0100
Subject: [PATCH] debian/rules: use fake HOME for tests

Use a fake home directory for tests to ensure that no data in the real
home directory is replaced during package build.
---
 debian/rules | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/rules b/debian/rules
index eaa101b..d6b3496 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,6 +10,6 @@
 #override_dh_auto_build:
 
 override_dh_auto_test:
-	mocha -R spec test.js
-
-
+	mkdir -p test-home
+	HOME=$(shell pwd)/test-home mocha -R spec test.js
+	rm -rf $(shell pwd)/test-home
-- 
2.10.2


Reply to: