Bug#840676: [pkg-go] Bug#840676: RFP: golang-github-kardianos-osext -- Extensions to the standard "os" package
Control: reassign -1 golang-github-kardianos-osext-dev
Control: retitle -1 golang-osext: Packaging cleanups and new upstream release
Control: found -1 0.0~git20151222.0.29ae4ff-1
On Thu, 2016-10-13 at 20:25:11 +0000, Potter, Tim (HPE Linux Support) wrote:
> On 14 Oct 2016, at 5:44 AM, Guillem Jover <gjover@sipwise.com> wrote:
> > Package: wnpp
> > Severity: wishlist
> > Tags: patch
> >
> > * Package name : golang-github-kardianos-osext
> > Version : 0.0~git20160811.0.c2c54e5-1
> > Upstream Author : Daniel Theophanes
> > * URL : https://github.com/kardianos/osext
> > * License : BSD-3-clause
> > Programming Lang: Go
> > Description : Extensions to the standard "os" package
> Hi Guillem. This package is already in Debian under the source package name
> "golang-osext". It's not the latest version though, so there is still some work
> that can be done here.
Ah right, sorry, should have been looking for the binary package name
instead. Ok, then let's convert this into a bug against that package,
as cleanups and a request for a new upstream. :)
Attached the new diff.
(I've also renamed the Vcs field values, but those would need intervention
on alioth. :)
(Also, I noticed the choice of licensing for debian/* and while everyone
is obviously free to choose whatever they like, this kind of divergence
could create problematic siutation when adding local patches, as those
might not be acceptable to upstream for example.)
Thanks,
Guillem
diff -Naur golang-osext-0.0~git20151222.0.29ae4ff/debian/changelog golang-github-kardianos-osext/debian/changelog
--- golang-osext-0.0~git20151222.0.29ae4ff/debian/changelog 2016-04-30 17:19:42.000000000 +0200
+++ golang-github-kardianos-osext/debian/changelog 2016-10-14 13:13:32.373644305 +0200
@@ -1,3 +1,16 @@
+golang-github-kardianos-osext (0.0~git20160811.0.c2c54e5-1) UNRELEASED; urgency=medium
+
+ * New upstream version 0.0~git20160811.0.c2c54e5
+ * Use https URL in debian/copyright Format field.
+ * Add a Built-Using field.
+ * Remove unused shlibs:Depends substvar from Depends field.
+ * Remove redundant DH_GOPKG from debian/rules.
+ * Use _build as build directory.
+ * Rename source package name to match current Go packaging policy, as this
+ should not require going via NEW.
+
+ -- Guillem Jover <gjover@sipwise.com> Fri, 14 Oct 2016 13:07:09 +0200
+
golang-osext (0.0~git20151222.0.29ae4ff-1) unstable; urgency=medium
[ Tim Potter ]
diff -Naur golang-osext-0.0~git20151222.0.29ae4ff/debian/control golang-github-kardianos-osext/debian/control
--- golang-osext-0.0~git20151222.0.29ae4ff/debian/control 2016-04-30 17:08:51.000000000 +0200
+++ golang-github-kardianos-osext/debian/control 2016-10-14 13:12:59.197481432 +0200
@@ -1,4 +1,4 @@
-Source: golang-osext
+Source: golang-github-kardianos-osext
Section: devel
Priority: extra
Maintainer: Debian Go Packaging Team <pkg-go-maintainers@lists.alioth.debian.org>
@@ -6,13 +6,14 @@
Build-Depends: debhelper (>= 9), dh-golang, golang-go
Standards-Version: 3.9.8
Homepage: https://github.com/kardianos/osext
-Vcs-Browser: https://anonscm.debian.org/cgit/pkg-go/packages/golang-osext.git
-Vcs-Git: https://anonscm.debian.org/git/pkg-go/packages/golang-osext.git
+Vcs-Browser: https://anonscm.debian.org/cgit/pkg-go/packages/golang-github-kardianos-osext.git
+Vcs-Git: https://anonscm.debian.org/git/pkg-go/packages/golang-github-kardianos-osext.git
XS-Go-Import-Path: github.com/kardianos/osext
Package: golang-github-kardianos-osext-dev
Architecture: all
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${misc:Depends}
+Built-Using: ${misc:Built-Using}
Description: Extensions to the Go "os" package
Go library implementing functions for discovering the current
executable and folder to re-invoke the currently running program.
diff -Naur golang-osext-0.0~git20151222.0.29ae4ff/debian/copyright golang-github-kardianos-osext/debian/copyright
--- golang-osext-0.0~git20151222.0.29ae4ff/debian/copyright 2016-01-15 09:35:27.000000000 +0100
+++ golang-github-kardianos-osext/debian/copyright 2016-10-14 13:05:39.991237753 +0200
@@ -1,6 +1,6 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: osext
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/kardianos/osext
+Upstream-Name: osext
Files: *
Copyright: 2012 The Go Authors
diff -Naur golang-osext-0.0~git20151222.0.29ae4ff/debian/rules golang-github-kardianos-osext/debian/rules
--- golang-osext-0.0~git20151222.0.29ae4ff/debian/rules 2016-01-15 09:17:13.000000000 +0100
+++ golang-github-kardianos-osext/debian/rules 2016-10-14 13:08:43.956201246 +0200
@@ -1,6 +1,4 @@
#!/usr/bin/make -f
-export DH_GOPKG := github.com/kardianos/osext
-
%:
- dh $@ --buildsystem=golang --with=golang
+ dh $@ --buildsystem=golang --with=golang --builddirectory=_build
Reply to: