Hi Samuel,
> I've just created the git repo. and pushed hashid, i didn't push any tags
> because i believe we will only tag hashid when we update the manpage, if i
> did something wrong please feel free to point out.
Here are some things that can still be improved:
git
---
* HEAD is set on a non-existent ref. This is weird, I don't
know how you did that. The repository appears to be empty when you
clone it for the first time... :-)
* You can already push the 'upstream' tags. In fact, you should delete
the 'debian' tags if you have some, they should not exist for the
moment. You will tag the debian release after the upload of the
package.
debian/control:
---------------
* Since you're using pybuild, dh-python should be a Build-Dependency[0].
* According to Policy 5.6.2[1], multiple Uploaders entries must be comma
separated.
debian/rules:
-------------
* When using pybuild, better specify 'export PYBUILD_NAME=hashid'[2].
This is not mandatory for packages building only one binary package, but
I consider it as a good practice.
debian/dirs:
------------
* debian/dirs is useless since you're not overriding dh_auto_install
anymore. usr/bin should be automatically generated.
debian/changelog:
-----------------
* FYI, '[ Samuel Henrique Oltramari Pinto (SamuelOPH) ]' is not needed.
Advice: I'd recommend you to test your packages in the future. It would
allow you to detect your mistakes and correct them by yourself. There
are a lot of automated tools for that:
- lintian -iE --pedantic
- debc
- piuparts
- cme check dpkg
- duck
- licensecheck
- codespell
- check-all-the-things
etc.
Otherwise, everything looks ok.
Cheers,
Hugo
[0] https://wiki.debian.org/Python/Pybuild
[1] https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Uploaders
[2] https://anonscm.debian.org/cgit/dh-python/dh-python.git/tree/pybuild.rst
--
Hugo Lefeuvre (hle) | www.owl.eu.com
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
Attachment:
signature.asc
Description: PGP signature