Hi James, thanks for your suggestions! I have updated the dependencies and fixed the spelling errors. Also, thanks for hinting at README.Debian, that is indeed a better place for these setup instruction (although fewer people might look there). I'll still have to look at packaging the Chrome theme. The Firefox is no problem, since it is just plain CSS (I have already included it in vertex-theme.install). However the Chrome theme (in extra/Chrome) features CRX files [0] as well as a source directive. Maybe I can figure out how to 'create' those CRX files and then ship them. Best Regards, Jack Henschel On 08/18/2016 02:32 AM, James Lu wrote: > (Disclaimer: I'm not a DD with upload privileges or anything, just a > customization enthusiast with a bit of packaging knowledge.) > > But, some notes anyways on a first glance: > > * https://github.com/horst3180/vertex-theme lists gnome-themes-standard > as a dependency, but that's missing from debian/control > > * A man page for something like a theme set seems a bit odd to me; > aren't those usually for binaries or config files? AFAIK, README.debian > is the most common way of writing notes such as how to configure extras: > see https://www.debian.org/doc/manuals/maint-guide/dother.en.html#readme > > * I noticed some typos in the man page: enviroments instead of > environments (line 8), IceWeasel instead of Iceweasel (line 9) > > Other than that, the package looks fine to me :) > > Best, > James > > On 17/08/2016 2:48 PM, Jack Henschel wrote: >> My progress is now in collab-maint (vertex-theme): >> >> https://anonscm.debian.org/git/collab-maint/vertex-theme.git >> git://anonscm.debian.org/collab-maint/vertex-theme.git >> >> I'm using gbp with the branches master, upstream and pristine-tar. >> >> What still needs to be done: >> >> * Check dependencies >> * Complete and verify manpage >> >> Oh, and also I still need to fix all the other mistakes I probably made :-) >> >
Attachment:
signature.asc
Description: OpenPGP digital signature