[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#745027: Status



On Fri, Aug 12, 2016 at 07:19:06PM +0200, Filip Pytloun wrote:
> Hello,
> 
> I have finally got some time to move this forward.
> 
> Packaged dependencies:
> 
>   python-atomicwrites
>   python-click-log
>   python-click-threading (waiting in NEW)
> 
> and almost finished vdirsyncer packaging to be under PAPT team, now
> waiting for review [1] and accept of python-click-threading.
> 
> [1] https://github.com/fpytloun/debian-vdirsyncer/tree/master/debian
> 
> Filip

Hello Filip,

First, thanks for your efforts! I really apprechiate your work.

I see that you have added a few patches to your Debian package.

> 0001-Do-not-require-setuptools-scm.patch

I couldn't find how you're getting the sourcecode, but this should not be
necessary if you're using the tarballs from PyPI. See
https://vdirsyncer.pimutils.org/en/stable/packaging.html#obtaining-the-source-code

It appears that python3-setuptools-scm is also available in Debian, so adding
it as build dependency (instead of runtime dependency) should be possible.

It seems that this is a bit unclear as I've discovered a similar patch in
Fedora. Please rather reach out and discuss things with me before doing this.
I'm saying this because I suspect that the metadata for the installed package
will be wrong (Python software can query the installed version of a package
with the `pkg_resources` module) because setup.py now doesn't contain any
version information.

> 0002-Don-t-use-subtest.patch

Fair enough, it is a pretty small package.

> 0003-Skip-ssl-tests.patch

This might be caused by the `HTTP_PROXY` and `HTTPS_PROXY` envvars. I'd try
unsetting them in the build environment.

> 0004-Include-license-from-copyright-file.patch

As far as I understand, this is including this file:
https://github.com/fpytloun/debian-vdirsyncer/blob/master/debian/copyright

However, the LICENSE file should be included in the PyPI package.

Please do reach out if you encounter problems.

Cheers,
Markus

Attachment: signature.asc
Description: PGP signature


Reply to: