On Monday, July 18, 2016 08:34:33 PM Valentin Samir wrote: > Le lundi 18 juillet 2016 à 01:57 -0400, Scott Kitterman a écrit : > > I did take a quick look at the package. One comment I'd make right > > away is to > > be more verbose in your initial changelog entry, particularly explain > > what the > > patch that's included is there for. > > I don't do much sponsoring outside of a team context, but if you were > > willing > > to maintain the package in PAPT, I would be willing to sponsor it. > > > > I also took a quick look at the upstream code since I'm also upstream > > for a > > Python based policy server. I noticed you're using netaddr. The > > ipaddress > > module included in python since 3.3 will easily do what you're using > > netaddr > > for and would get rid of an external dependency. > > > > Let me know if you're interested in PAPT. If so, we'll go from > > there. > > I update upstream to use ipaddress according to your recommendations. > I also added a phrase to explain the purpose of the patch to the > changelog, tell me if it's enougth (updated package is on https://mento > rs.debian.net/package/policyd-rate-limit). > > I am interested in PAPT for maintaining the package. Should I join the > team ? Could you instruct me what I have to do for that. Great, Please see https://wiki.debian.org/Teams/PythonModulesTeam/HowToJoin Scott K
Attachment:
signature.asc
Description: This is a digitally signed message part.