Bug#813096: ITP: logdata-anomaly-miner -- lightweight tool for log checking, log analysis
Hi
>Strange, the debian-mentors did not show those and also running "lintian logdata-anomaly-miner_0.0.2_all.deb" locally does not yield all of those. Trying to fix >anyway:
mentors is about source uploads, lintian on binaries can't run there
> E: logdata-anomaly-miner: python-script-but-no-python-dep
>Tried to follow the guidelines, seems that everything works but lintian is still complaining. Changes recommended from various forums:
>Any ideas would be appreciated. Otherwise I'll just add a workaround to get rid of the lintian error.
I still don't see "python" in build-dependencies.
BTW your rules hack is wrong, please just call dh --with=systemd,python2
BTW "python2.6 | python2.7" <-- please remove dh_python2 should handle them too
> W: logdata-anomaly-miner: maintainer-script-calls-systemctl prerm:30
> W: logdata-anomaly-miner: maintainer-script-calls-systemctl prerm:31
Gone by following changes .... (BUT read below):
>CAVEAT: Although lintian is happy, there are two issues with that change, that may/are problematic:
>
>a) I moved the DEBHELPER in prerm BEFORE my code to delete the users. Is the DEBHELPER code really intended to be run before or may this cause other issues?
what about a "postrm" script?
>b) In postinst DEBHELPER will automatically activate the systemd unit. But this was not done INTENTIONALLY! Therefore documentation included a section, what to >check/do before activating the service to avoid any risks. Are there means to get to that state also with the dh-systemd components?
preinst?
>Thanks for the hint. If I understand correctly, pybuild will only care about maintaining the dependencies to the python packages and which interpreter to use but it >will NOT require the software to load from site-packages or to create/use pyc files, which is currently avoided due to security reasons?
I'm not sure :( sorry
>According to Debian manual, this should be used to automatically include files from uppermost directory of the unpacked source. Currently there are no useful files >at this location, all documentation is included directly from source/root/usr/share/doc/aminer/. Would following files be sufficient?
an empty file can be deleted, if you have no documentation, but having an empty file should be avoided
(I don't like them, they overcomplicate packaging and are just useless)
>This was a workaround for a problem (build error), which seems to be fixed by restructuring of the build anyway. Removed.
yes, the reason for asking you is: "please create directory at build time, don't ask Debian to create them, because the problem is general, not Debian specific)
>Current content is "root/* ." There is no compiling involved, so this copies just the plain files into the package. Is there something else to be used for this >purpose?
not sure, does dh_systemd correctly handle the service file?
>How should that work? In generated DEBHELPER code I do not see any commands that would create the users? If you mean the length of " >abort->upgrade|abort->remove|abort-deconfigure": this is from dh-make, should that be changed?
yes, just override what you need, don't put default stuff there
(and open a built-deb file, you will see the #DEBHELPER# macro substituted
>This was not really planned. The idea behind the package structure was to have only one repository to maintain to build the packages for both Debian/Ubuntu. Will >the Debian/Ubuntu requirements be that different in the end, that maintaining a single code base for building is not possible anyway? In such scenario are those >changes the best?
create an upstream tarball, and switch to quilt mode, the code doesn't change for Debian, or Ubuntu, and makes easier for other linux
distros to use it.
>* Move the debian/ stuff in the upstream repository to debian-templates/ (not packaged)
not requested.
>* Create a downstream repository, e.g. at the "Debian collab platform", where the upstream source.tgz is loaded automatically and only the debian/ stuff is stored
>Does that make sense?
you can also just remove the debian from the orig tarball, and add it on top of your changes after unpacking the orig tarball.
(I hope I answered to everything)
G.
Reply to: