Bug#697821: ITP: ppsspp -- ppsspp: A portable PSP emulator.

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

(disclaimer to Adrian, I don't want to steal that package to you :) )



Hi Serio, Adrian,


>Yes, I'm aware of that. I was busy fixing the fallout of the libpng1.6 transition and there is lots of packages that we need to fix.


FYI, we are currently tracking problems here, feel free to contribute or check here if we already have fixes (or schedule give-backs)

https://titanpad.com/SjTUuZTd01
>Well, I'm not quite sure why you care about that. The package has to be reviewed by a Debian Developer anyway. So, you don't have to do that.


I'm stepping in just because I would like to see if the package builds, to spot libpng1.6 issues.

Just some stuff I saw in my quick trip.
fonts-droid is a virtual package, either choose fonts-droid-fallback or whatever else
lintian overrides are wrong:
paragraph at line 101 (override comment: lintian false positives)

this is because the copyright has to list from the generic to the specific files

so, swapping e.g.
Files: Common/Crypto/*
Files: Common/Crypto/sha256.*
Files: Common/*

to
Files: Common/*
Files: Common/Crypto/*
Files: Common/Crypto/sha256.*

should fix the issue.

Hope this helps,

another "nitpick"/issue
+find_path(PNG_PNG_INCLUDE_DIR NAMES "libpng16/png.h")


please please please use libpng/png.h instead, I don't want another ton of NMUs
for the next png transition
(also all the includes are wrong #include<libpng/png.h> is completely legit and ok)


I leave the other stuff to your sponsor, I tried to keep the review png-related only


thanks to you both,


Gianfranco