Hi Peter
On 2016-01-16 22:13:53, Sebastian Ramacher wrote:
> On 2016-01-14 02:52:58, Peter Spiess-Knafl wrote:
> > Dear pkg-multimedia-maintainers!
> >
> > I am currently packaging a software called nordlicht.
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809923
> >
> > Upstream is very collaborative on fixing things or applying patches.
> > Here is the ongoing discussion:
> >
> > https://github.com/nordlicht/nordlicht/issues/38
> >
> > I got hinted that it might be relevant to the pkg-multimedia team, so I
> > am proposing it here.
> >
> > The package is currently developed at collab-maint:
> > http://anonscm.debian.org/cgit/collab-maint/nordlicht.git/
Also, here is a first review:
A new upstream version is available.
Why is linbpng-dev in Build-Depends? It doesn't seem to be used.
Is there a reason libnordlicht0 and libnordlicht-dev are not multi-archified?
The library exports plenty of symbols that are not listed in nordlicht.h. Please
hide those symbols (for example using __attribute__(visibility("hidden"))) and
ideally get this fixed upstream.
nordlicht is overlinked:
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nordlicht/usr/bin/nordlicht was not linked against libavcodec-ffmpeg.so.56 (it uses
none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nordlicht/usr/bin/nordlicht was not linked against libavformat-ffmpeg.so.56 (it use
s none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nordlicht/usr/bin/nordlicht was not linked against libavutil-ffmpeg.so.54 (it uses
none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/nordlicht/usr/bin/nordlicht was not linked against libswscale-ffmpeg.so.3 (it uses
none of the library's symbols)
libnordlicht.so.0 is underlinked. Please link it against libm:
dpkg-shlibdeps: warning: symbol log10 used by debian/libnordlicht0/usr/lib/libnordlicht.so.0 found in none of the libraries
Cheers
--
Sebastian Ramacher
Attachment:
signature.asc
Description: PGP signature