[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#801253: O: wicd -- wired and wireless network manager



Ok, one more round.

Axel Beckert wrote:
> toogley wrote:
> > https://github.com/toogley/pkg-wicd/commit/b2931ca51f831369ec2854b20b523ba9db42546a
> 
> Thanks, just in time. I already started the final compilation, but I
> have neither uploaded nor pushed the changelog finalisation.

This is still true.

Axel Beckert wrote:
> Didn't look close enough. I expected a fix below, but that's just a
> changelog entry.
> 
> Since this was fixed in a previous version,

(As toogley mentioned in the commit message.)

> it doesn't belong into the current changelog entry.

Which toogley didn't do.

> The common way to close such bugs is to close them directly in the
> bug tracking system with a comment that it has already been fixed in
> version XYZ.

Adding it to a previous changelog entry is ok-ish for me, but there
seem quite some people in Debian who don't like it.

Axel Beckert wrote:
> Re-reading that mail, I noticed that he didn't say that it's fixed in
> 1.7.2.4 but he tested it against 1.7.2.4.
> 
> So I'll fetch your commit and integrate it.

... into the 1.7.3 changelog entry. :-)

> Thanks again and sorry for the confusion.

Still counts. ;-)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: