On Thu, 2015-07-30 at 16:58 +0200, Alessandro Ghedini wrote: > On Thu, Jul 23, 2015 at 03:58:55AM +0100, Luca Boccassi wrote: > > owner 630761 luca.boccassi@gmail.com > > thanks > > Note that you need to CC control@bugs.debian.org for this to work, or you can > use the "Control" pseudo-header. Silly me, thought I CC'ed it and didn't go back to check. Thanks for the reminder! > So, I had a look at the package and here are a few notes: > > * The changelog entries should be merged into a single one since it would be > the first upload for the package. There's no need to list all the changes > there either, the "Initial release" message with the closed bug is enough. Done. I kept only 2 entries, one for each patch, as I think it's useful information for a Changelog, if it's all right with you. > * The -dev package should just be named libczmq-dev (i.e. without the version), > this way next time the project bumps the SONAME it'll be easier to do the > transition (you won't have to update all the reverse build dependencies). > > * Same goes for -dbg, but it's less important in that case. Reasoning for this choice was to follow what libzmq does, since the maintainer is making both libzmq1 and libzmq3 (and libzmq5 in experimental) available at the same time, and I thought in the future I'd do the same for libczmq. But thinking about it, the key difference is that upstream still maintains older versions of libzmq, but there is only one branch in libczmq, older versions did not get bugfix releases in the past so probably it won't happen in the future. So, done as you suggested :-) > * The Conflicts field is not needed either way since the libczmq-dev package > doesn't exist (and if you do rename the -dev package the Provides field is > not needed either). Done. > * The README.source doesn't really provide any useful information, so it can > be removed (also, since the dh-autoreconf plugin is used, the tarball > generated from GitHub would probably work as well). I added it since there is a discrepancy between the tarballs on the official website and Github, and to explain it. If it is all right with you, I would rather keep using the tarball from the website, for 2 reasons: 1) The package is smaller, and the autotools chain is already generated, which means less maintenance and faster build times for us (autoreconf is temporary, my patch has been merged so I will drop it eventually, when they do a new release). 2) At the moment, the Github tarball ships with an object file (src/foreign/sha1/sha1.o) (I sent a patch to remove it and it has been merged upstream), which means I would have to re-package it and mark it as ds, since it is against policy as far as I understand. The tarball on the website is sanitised and does not have this problem, so unintended files are less likely to fall in now or in the future. > * No need to use both autotools-dev and dh-autoreconf. autoreconf is enough. Done. But please note that, as I wrote above, once a new release happens I plan to drop autoreconf, since my patch has been merged and re-generating the autotools chain will no longer be necessary. This will be an advantage because the build system will be closer as upstream intends to, and also means faster build times and less maintenance for us. > * No need to override the debian-watch-may-check-gpg-signature lintian warning > (but it's not a problem if you want to do it anyway...). It was giving a warning on the Mentors upload page, so I added it. I'd like to keep it overridden if you don't mind :-) > * Generally it's better to license the debian/* files under the same license > of the project, in this case MPL-2.0. It seems that when the project was > relicensed from the LGPL-3+, Arnaud decided to put the debian files under > GPL-3 (without my consent...) which IMO doesn't make a lot of sense. Moved debian/* to MPL-2.0. > * You can safely remove Gergely and myself from the Uploaders list. I think > it's also safe to remove Arnaud as well since he's been inactive for a while > (he can always be added back if needed). Done. > * You might want to update the page at http://zeromq.org/distro:debian with > your name. Done. > I think that's all, though I might have missed something. Thank you very much for your feedback, it's very welcome! I also dropped libpgm-dev from the build-dep, as it is actually not needed (it's a dependency of libzmq-dev, and it pulls it in itself). I pushed all changes to the repo [1]. > So, anyway, I'm open to sponsoring the package if needed, since Arnaud seems to > be inactive. Once you've fixed the above just ping me and I'll have another look > (no need to upload the package to mentors.d.n, I only use git anyway). Last week I talked to the ZMQ maintainer, László [CC'ed], and he expressed interest in sponsoring, but I think he is busy or away now, so if you think the package is in a good state to be uploaded I would be very happy to get the upload done with. Thank you, I really appreciate it! Kind regards, Luca Boccassi Brocade Communications Systems [1] http://anonscm.debian.org/cgit/collab-maint/czmq.git/
Attachment:
signature.asc
Description: This is a digitally signed message part