Dominique Dumont <dod@debian.org> writes: > On Tuesday 17 March 2015 00:23:51 Daniel Dehennin wrote: >> Now it builds cleanly in a schroot, I even install the package and “moar >> --help” works \o/. > > I've begun to review the package. A couple of comments: > > * I think /usr/lib/moar/libmoar.so should land in a multiarch path (even > though libtommath.so is not currently multiarch...) The library is not versioned[1], so I thought it should not. > * copyright is missing Upstream-contact Should I set it to some upstream author or the http://moarvm.org/contributing.html URL? > * Expat license is duplicated in debian/copyright (which would have > been avoided if you were using cme ...) I tried “cme fix dpkg-copyright” but it does nothing :-/ I fixed it by hand and add the Vcs-* fields too. Thanks. Footnotes: [1] https://github.com/MoarVM/MoarVM/issues/74 -- Daniel Dehennin Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
Attachment:
signature.asc
Description: PGP signature