Hi Sriram,(Cc:ing Bernhard and the RFH bug report for freerdp. In Debian, we have to communicate as publicly as possible, so that other people see progress and learn from what we do / can join in later on)
On Do 08 Okt 2015 18:26:38 CEST, sriram wrote:
Hi Mike, There are few upstream patches available for some of the bugs, few bugs I'll fix them. - One I've already fixed and pushed.
Yeah, just looked at it. The commit is good, but the commit message could be more explainative. Please note that I personally like using
git dch --autofor debian/changelog generation. With that command it is very helpful that git commit messages are phrased in a way they can right-away end-up in debian/changelog.
Please don't change the commit message now (because force-pushing should be avoided).
A more descriptive message could have been: """debian/control: Fix typo in LONG_DESCRIPTION of bin:package libwinpr-library0.1.
"""
How does, review or moving from here goes?
I'd say that you prepare patches against freerdp in unstable for open bugs. If you find new bugs while testing, submit new bug reports (possibly with a patch already).
If you find a patch that really solves an issue, please add the patch to the package and prepare a .debdiff between the old and the new package version. Send that .debdiff to the bug report first for introspection (so we don't clobber Git history too much when making mistakes). Don't forget tagging the bug report with the "patch" tag (see [1] for details on tagging bugs in Debian BTS).
The process of creating .debdiff files has been described by Raphael Hertzog [2].
The details are as below: - freerdp-x11: RemoteApps is broken: error: expected PDU_TYPE_DEMAND_ACTIVE 0001, got 0007 Has an upstream branch.
Please prepare .debdiff for this fix.
- #768855 libwinpr-library0.1: typo in package description - Fixed and pushed.
Seen. Comments: see above.
- #788005 libfreerdp-plugins-standard: urbdrc-client.so missing (USB redirection) - Will fix this by tomorrow.
Ok. Create a .debdiff when ready.
Shall start working on these below over the weekend and try to check them soon. #590996 [n|R| ] [libfreerdp-plugins-standard] libfreerdp-plugins-standard: Clipboard synchronisation over RDP does't work in some cases
This bug is really old and has been reported against a very early version of freerdp. If the bug report does not apply to any version in Debian anymore, please close it via mail. Please include <nnnn>-submitter@bugs.debian.org in Cc:, so that the bug submitter also receives info on the bug closure.
#679926 [n|u| ] [freerdp-x11] freerdp-x11: Add MAXIMIZED X-properties with "workarea" geometry
Ok... It probably would be good to get a comment from Bernhard on all those open issues. Just in case, fixes have been upstream, too.
#778650 [n| | ] [freerdp-x11] freerdp-x11: Alt key gets "stuck" with -grab-keyboard option when using Alt-Tab to switch between local X windows
Ok... Again: comment from Bernhard?
Let me know your thoughts.
In general, I think we should get some of the above issues fixed in unstable, because those fixes can easily be backported to Debian jessie. I guess various of those fixes we should target for a jessie-proposed-upload version of freerdp.
Greets, Mike [1] https://www.debian.org/Bugs/server-control[2] https://raphaelhertzog.com/2011/07/04/how-to-prepare-patches-for-debian-packages/
-- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
Attachment:
pgpKTApSFwqTN.pgp
Description: Digitale PGP-Signatur