Bug#697821: ITP: ppsspp -- ppsspp: A portable PSP emulator.
Hi Sergio!
On Wed, Oct 07, 2015 at 08:03:11PM -0300, Sérgio Benjamim wrote:
> The package is updated to 1.1.0.
There are several lintian errors and warnings that you should get rid
of. Most notably, lintian complains about an embedded libpng:
E: ppsspp-sdl: embedded-library usr/games/ppsspp-sdl: libpng
N:
N: The given ELF object appears to have been statically linked to a
N: library. Doing this is strongly discouraged due to the extra
work needed
N: by the security team to fix all the extra embedded copies or
trigger the
N: package rebuilds, as appropriate.
N:
N: If the package uses a modified version of the given library it
is highly
N: recommended to coordinate with the library's maintainer to
include the
N: changes on the system version of the library.
N:
N: Refer to Debian Policy Manual section 4.13 (Convenience copies
of code)
N: for details.
N:
N: Severity: serious, Certainty: possible
N:
N: Check: binaries, Type: binary, udeb
N:
This might be a false alarm, but you should verify it in any case as
the FTP team will most likely reject the package if its binaries
contain any embedded libraries.
lintian also complains about unused paragraphs in the copyright file:
I: ppsspp source: unused-file-paragraph-in-dep5-copyright paragraph at
line 254
N:
N: The Files paragraph in debian/copyright is superfluous as it is
never
N: used to match any files. You should be able to safely remove it.
N:
N: Refer to
N:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Severity: minor, Certainty: possible
N:
N: Check: source-copyright, Type: source
N:
I: ppsspp source: unused-file-paragraph-in-dep5-copyright paragraph at
line 91
I: ppsspp source: unused-file-paragraph-in-dep5-copyright paragraph at
line 95
As well as the extended description being too short:
I: ppsspp-common: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The
extended
N: description should provide a user with enough information to
decide
N: whether they want to install this package, what it contains, and
how it
N: compares to similar packages. One or two lines is normally not
enough to
N: do this.
N:
N: Refer to Debian Developer's Reference section 6.2.1 (General
guidelines
N: for package descriptions) and Debian Developer's Reference
section 6.2.3
N: (The long description) for details.
N:
N: Severity: minor, Certainty: possible
N:
N: Check: description, Type: binary, udeb
N:
Note that the extended description should actually introduce your
package to users who have never heard of it before. Thus, your
description is actually a bit too short for someone who doesn't know
what ppssppp actually is.
If you like, you can use my description that I wrote back when I first
packaged ppsspp for Debian:
Description: A portable PSP emulator
ppsspp is a cross-platform emulator for Sony's PlayStation
Portable handheld console. The emulator features a built-in
just-in-time compiler (JIT) to quickly translate the CPU
instructions of the PSP into native code of the host system,
thus providing high performance on platforms where the JIT
is supported (currently x86 and x86_64, soon ARM). Supported
platforms include all major desktop operating systems as well
as various smart phone platforms like Android.
In case you didn't know, please always run lintian against the changes
file of the freshly built binary packages with:
lintian -i -E -I --pedantic ppsspp_1.1.0-1_amd64.changes
Running lintian against the source changes file or omitting any of the
options above may lead to important lintian warnings or errors being
missed.
Please fix the issues above, then I'll upload ppsspp to unstable. The
rest of the package looks fine so far. Well done!
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Reply to: