Bug#752018: Wildfly package
On 2015-04-03 10:06, Konstantin Manna wrote:
> Hi Julian,
>
Hi,
Just a drive-by remark. For extended help, please consider reaching out
to debian-java@lists.debian.org if you haven't already done so. :)
> thanks for the update.
> Lintian does not yet like your package :-)
>
> lintian --pedantic wildfly_8.1.0.final+lam.r01_all.deb
If you want to fully "unleash" lintian, you can use "-EvIL +pedantic"
and then remove the "v" (verbose) now remember the arguments. ;)
(For reference, --pedantic does not enable the I tags and you might want
to ignore the X as they are eXperimental).
> [...]
A lot of these suggests that the package has been built "manually" via
dpkg-deb from a recompiled upstream version instead of built from
source. It is entirely possible that I am wrong here - I have only
looked at this mail and not at the package.
Generally, you will want a source package that compiles all the java
files into class files, packs them into .jar files and installs those
into package directories. Usually with debhelper or cdbs taking care of
the heavy lifting the packaging side.
If upstream uses maven, you might want to use debhelper +
maven-debian-helper (or maybe cdbs + maven-debian-helper). I have not
tried that combo myself, so please contact debian-java for support on that.
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/domain/configuration/application-roles.properties 0600
> != 0644
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/domain/configuration/application-users.properties 0600
> != 0644
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/domain/configuration/mgmt-groups.properties 0600 != 0644
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/domain/configuration/mgmt-users.properties 0600 != 0644
> W: wildfly: non-standard-dir-perm usr/share/wildfly/domain/tmp/auth/
> 0700 != 0755
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/standalone/configuration/application-roles.properties
> 0600 != 0644
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/standalone/configuration/application-users.properties
> 0600 != 0644
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/standalone/configuration/mgmt-groups.properties 0600
> != 0644
> W: wildfly: non-standard-file-perm
> usr/share/wildfly/standalone/configuration/mgmt-users.properties 0600 !=
> 0644
> W: wildfly: non-standard-dir-perm usr/share/wildfly/standalone/tmp/auth/
> 0700 != 0755
These permissions are probably correct! If they contain passwords,
authentication tokens, or "secret" information (encryption keys) then
they should certainly *not* be world readable. Overriding the tag would
be correct here.
*However*, the location of these files are almost certainly wrong. The
".properties" file smells like something an admin might change and
therefore should be in /etc/ (e.g. /etc/wildfly/...). Alternatively, if
they are templates files they should be world-readable (there is no
point in having them be non-readable).
The ".../tmp/" part might want to be in /run/wildfly/ or something like
that instead. That said, the application must be able to create it if
it is missing since /run is generally a tmpfs.
> W: wildfly: script-in-etc-init.d-not-registered-via-update-rc.d
> etc/init.d/wildfly
> E: wildfly: init.d-script-does-not-implement-required-option
> etc/init.d/wildfly force-reload
Upstream stuff
> W: wildfly: codeless-jar
> usr/share/wildfly/modules/system/layers/base/org/jboss/as/console/main/release-stream-2.2.6.Final-resources.jar
> W: wildfly: codeless-jar
> usr/share/wildfly/modules/system/layers/base/org/jboss/as/domain-http-error-context/main/wildfly-domain-http-error-context-8.1.0.Final.jar
> W: wildfly: codeless-jar
> usr/share/wildfly/modules/system/layers/base/org/jboss/as/webservices/main/jbossws-cxf-resources-4.2.4.Final-wildfly800.jar
> W: wildfly: codeless-jar
> usr/share/wildfly/modules/system/layers/base/org/jboss/ws/cxf/jbossws-cxf-factories/main/jbossws-cxf-factories-4.2.4.Final.jar
Theses *might* be correct. Some packages provide "meta" jars files,
which sole purpose is to depend on other jar files (e.g. eclipse have a
number of these). /If/ so, then just override the tag.
> W: wildfly: maintainer-script-ignores-errors preinst
> W: wildfly: maintainer-script-ignores-errors postrm
Sounds easy to fix, but might require a careful review of the scripts.
In fact, if you can do without any (manually written) scripts, you are
off to a good start[1]. Based on the next warnings, you probably
*cannot* (unfortunately).
[1] They require a bit of effort to "get right" and also a bit of
testing. Even minor flaws trivially becomes an RC bug because it breaks
installability or etc. Remember that in "pre*" you got only have
"essential" packages available.
> W: wildfly: maintainer-script-should-not-use-deprecated-chown-usage
> postinst:6 'chown -R wildfly.wildfly'
> W: wildfly: maintainer-script-should-not-use-deprecated-chown-usage
> postinst:7 'chown -R wildfly.wildfly'
> W: wildfly: maintainer-script-should-not-use-deprecated-chown-usage
> postinst:8 'chown -R wildfly.wildfly'
Trivial fix is probably s/wildfly\.wildfly/wildfly:wildfly/
> [...]
> Would you like to fix that?
> I guess if the package is lintian clean and we can find a debian mentor
> we might get the package into the official repos.
>
> Cheers,
> Konstantin
>
Good luck with the work and thanks for considering to contribute to
Debian. :)
Thanks,
~Niels
Reply to: