Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG

[Simon McVittie <smcv@debian.org>]

On 15/02/15 11:38, Tobias Frost wrote:
> +Recommends: dhewm3-d3xp

You could use 'debian: engine: dhewm3-d3xp', assuming dhewm3-d3xp
Depends on any other parts of dhewm3 that it needs.

Alternatively, you could bundle together the open-source bits for both
the base game and RoE in one .deb, just like Quake 3 + Team Arena, and
use symlinks or TryExec to hide the RoE launcher if the RoE data is not
installed.

On 15/02/15 12:09, Tobias Frost wrote:
> (But maybe you can take a look at my commit -- It seemed to ignore
> the longname for the RoE expansion pack, the resulting package
> doom3-resurrection-data had as Description: "Doom 3 (original or BFG
> Edition)" -- I expected to gdp to use the longname specified in its
> packages: specification; I worked around by specifiing it in the
> doom3-resurrection-data.control.in, which I had anyway to specify the
> correct dependencies on the game logic *.so)

This logic:

            if package.expansion_for:
                short_desc = 'extra data for ' + self.longname
            else:
                short_desc = 'data for ' + longname

is not great when self.longname is something like "Doom 3 (original or
BFG edition)". We would probably get better results by using

short_desc = 'data for ' + longname

unconditionally.

We could maybe also replace:

            if package.expansion_for:
                long_desc += ' Expansion: ' + longname
            else:
                long_desc += ' Game: ' + longname

with:

            if package.expansion_for:
                game_name =
self.packages[package.expansion_for].longname or self.longname
                long_desc += ' Game: ' + game_name + '\n'
                long_desc += ' Expansion: ' + longname
            else:
                long_desc += ' Game: ' + longname

Regards,
    S