[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#733910: Added ckon to highenergy-physics-dev (as per your SoB Wiki entry)



Hi Patrick.

On Mon, Jan 26, 2015 at 10:18:49AM +0100, Andreas Tille wrote:
> please specify in what task(s) of Debian Science ckon would fit into.

As per your Wiki entry I added

$ git diff HEAD^
diff --git a/tasks/highenergy-physics-dev b/tasks/highenergy-physics-dev
index 9340ebd..7c175f9 100644
--- a/tasks/highenergy-physics-dev
+++ b/tasks/highenergy-physics-dev
@@ -57,3 +57,5 @@ Depends: libthepeg-dev
 Suggests: thepeg-reference
 
 Depends: herwig++-dev
+
+Suggests: ckon


which will put this package on the according tasks page after the next
cron cycle.  Please make sure that this will happen (for instance by
pinging the Debian Science list) before adding a package to the SoB Wiki
next time you want to get a package sponsored.  My motivation to run SoB
is just to make sponsees aware of the whole picture - merging packages
into tasks is part of it.

Regarding the packaging:  I noticed some issues in debian/control which
can very easily fixed by using Config Model Editor (cme):

$ cme fix dpkg-control
Fixing dpkg-control configuration...
Paketlisten werden gelesen... Fertig
Abhängigkeitsbaum wird aufgebaut.       
Statusinformationen werden eingelesen.... Fertig
Connecting to qa.debian.org to check 4 package versions. Please wait...
got info for 4 packages: debhelper dh-autoreconf libboost-all-dev libcurl4-openssl-dev
Warning in 'source Standards-Version' value '3.9.5': Current standards version is 3.9.6
Warning in 'source Vcs-Browser' value 'http://git.debian.org/?p=debian-science/packages/ckon.git': URL to debian system is not the recommended one (code is: '!defined $_ or ! /debian.org/ or m{^https?://anonscm.debian.org/(viewvc|cgit|loggerhead)} ;')
Warning in 'source Vcs-Git' value 'git://git.debian.org/git/debian-science/packages/ckon.git': URL to debian system is not the recommended one (code is: '!defined $_ or ! /debian.org/ or m{^http://anonscm.debian.org/git/(?!git/)} or m{^git://anonscm.debian.org/(?!git/)} ;')
Element 'DM-Upload-Allowed' of node 'source' is deprecated

Changes applied to dpkg-control configuration:
- source DM-Upload-Allowed : dropping deprecated parameter
- source Build-Depends:0: 'debhelper (>=9)' -> 'debhelper (>= 9)' # applied fix
- source Standards-Version: '3.9.5' -> '3.9.6' # applied fix
- source Vcs-Browser: 'http://git.debian.org/?p=debian-science/packages/ckon.git' -> 'https://anonscm.debian.org/cgit/debian-science/packages/ckon.git' # applied fix
- source Vcs-Git: 'git://git.debian.org/git/debian-science/packages/ckon.git' -> 'git://anonscm.debian.org/debian-science/packages/ckon.git' # applied fix


I pushed the resulting changes - please inspect them thoroughly and try
to establish the habit to run "cme fix dpkg-control". :-)  (Feel free to
revert some formating changes done by cme if you do not like these.)

debian/README.source:  Please remove this useless boilerplate or add
some interesting content.

debian/changelog:  The latest changelog entry should close the ITP bug
and not any random previous version.  I'd recommend to remove all old
entries and just leave the recent one - or alternatively set the target
distribution from unstable to UNRELEASED to make sure everybody will
understand that 0.7.1-1 is the first upload to Debian.  I personally
would prefer removing entries which are irrelevant for Debian and as far
as I know ftpmasters who need to read all this are as well.

debian/copyright:  It is really great if the upstream maintainer cares
for the Debian package as well.  So it is correct not to use an extra

Files: debian/*

paragraph in d/copyright.  However, I personally do this for
clarification issues.  Feel free to ignore this hint and keep the file
as is.

debian/rules:  Hmmm, other sponsees know that I'm a bit allergic against
remaining boilerplates.  Doe you really think that your d/rules file is
a "Sample debian/rules that uses debhelper"?  If yes, why don't you
provide a real working d/rules file for your package? :-P

Please let me know if you fixed these issue and I check a build.

Kind regards
 
         Andreas.

-- 
http://fam-tille.de


Reply to: