[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#744119: RFP: libonion -- lightweight and easy to use HTTP server library



Hi,

I just commited the changes to the debian branch (https://github.com/davidmoreno/onion/tree/debian).

About not using the debian directory, just now is to ease the compilation by third parties. I would really love to keep the debian packaging there at least by the moment, to help on current debian installations to easy create the packages.

If you see any other necesary change, please contact me.

Regards,
David.






2014-04-12 3:50 GMT+02:00 Thomas Goirand <zigo@debian.org>:
On 04/11/2014 03:34 PM, Andrei POPESCU wrote:
> Control: reassign -1 wnpp
> Control: retitle -1 RFP: libonion -- lightweight and easy to use HTTP server library
>
> On Jo, 10 apr 14, 14:07:07, David Moreno Montero wrote:
>> Package: libonion, libonion-dev, libonion-tools, libonion-examples
>> Severity: wishlist
>>
>> I'm the developer of libonion, a C HTTP server library with bindings for
>> C++. I would love to see it packaged for Debian. It has a working debian
>> directory that packages all needed files.
>>
>> https://github.com/davidmoreno/onion
>>
>> License is both GPLv2+ and Apache2 for the main library. AGPLv3 for the
>> examples and tools.
>>
>> --David Moreno Montero

Hi David,

It is a bad practice to ship a debian folder upstream. I would advice
you to at least rename it as something like "debian-upstream", so that
it doesn't conflict with the debian folder that will be worked on by the
maintainer of the package.

Now, a few remarks about your packaging.

1/ If you want to have your package in Debian, please clean the
debian/changelog, and write a single entry:

  * Intial release (Closes: #XXXXXX)

with XXXXXX the number of the ITP (Intention To Package) bug number (you
can open such a bug using "reportbug -b wnpp").

2/ There's no need to use debian/compat level 7 anymore. Increase this
to 9, as well as debhelper build-depends.

3/ Standards-Version: is now 3.9.5, fix that.

4/ Please rewrite your debian/copyright file in DEP5 format:
http://dep.debian.net/deps/dep5/

5/ The debian/libonion-dev.dirs is useless, remove it. Same for
debian/libonion.dirs

6/ The files usr/bin/interactive, usr/bin/fileserver, usr/bin/crl have a
way too much generic names, and may conflicts with other packages.
Please rename them (and possibly other files too).

7/ Switch to 3.0 (quilt) format for your debian source. To do so:

mkdir debian/source
echo "3.0 (quilt)" >debian/source/format

8/ Remove the comments in debian/rules, these are useless.

9/ Remove debian/README, there's nothing interesting there. Same with
README.source. There's a Homepage: field for this.

10/ Vcs-Git: and Vcs-Browser: are fields for the *packaging* urls, not
for your upstream source code.

11/ libonion-dev should depend on libonion (= ${binary:Version}

12/ libonion should be rename with as the soname. For example: libonion2

13/ libonion should use ${shlibs:Depends}, therefore there's no reason
that you even manually write the dependencies.

If you correct the above, I may sponsor your package upload in Debian.

Cheers,

Thomas Goirand (zigo)




--
David Moreno Montero 

dmoreno@coralbits.com
+34 658 18 77 17
+44 74 23 21 01 57

http://www.coralbits.com



Reply to: