[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#695194: help with webmock tests



On Sat, Apr 19, 2014 at 12:19 PM, Pirate Praveen <pravi.a@gmail.com> wrote:
>>> It needs ruby-em-http-request 1.1.2 but it seems to be not getting
>>> built even after 3 days. Do anyone know the reason?
>
> Finally em-http-request new version is available in unstable.
>
> I was able to run all tests in my local environment but it is failing
> in pbuilder. Can anyone try to run those? It is related to test/unit
> and minitest. My ruby expertise is almost nil and I won't be able to
> fix them myself. Other option is to disable these tests.
>
> /tmp/buildd/ruby-webmock-1.17.4/lib/webmock/test_unit.rb:9:in
> `alias_method': undefined method `teardown' for class `MiniTest::Test'
> (NameError)

I looked at this a bit.

Maybe you can just add an empty teardown method in
lib/webmock/test_unit.rb? Just add the following

      def teardown
      end

before alias_method on line 9. (There is probably some better and more
elegant way to handle this that I don't know of.)

When I did this the tests ran and seemed to report about actual test failures
instead of a failing run, complaining about failing stub_http_requests...


> Please review the patches also.

As I said on IRC, please split the patch that both removes rubygems from
tests (is this even necessary anymore?) and the porting to minitest into
two patches.


--
Per


> Thanks
> Praveen
> --
> പ്രവീണ്‍ അരിമ്പ്രത്തൊടിയില്‍
> You have to keep reminding your government that you don't get your rights
> from them; you give them permission to rule, only so long as they follow the
> rules: laws and constitution.
>
>
> --
> To UNSUBSCRIBE, email to debian-ruby-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: [🔎] CAOo+eVpeeymR6XTkzGTt42hRNoXLj3J4XnVSdSOF6KFxXixTTw@mail.gmail.com">https://lists.debian.org/[🔎] CAOo+eVpeeymR6XTkzGTt42hRNoXLj3J4XnVSdSOF6KFxXixTTw@mail.gmail.com
>


Reply to: