[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#722451: Adoption



Hello,

About amd64 packages and Debian: Since Knoppix has a 32bit as well as a
64bit kernel, but userspace is always 32bit in both cases, I personally
only need to build the i386 versions, these I provided at
http://debian-knoppix.alioth.debian.org/packages/compiz together with
the package sources. The source should build on plain Debian testing and
sid, regardless of bitness (i386 or amd64) on your system, I removed the
"Ubuntu specials" in the original debian/control dependencies and
debian/rules which would otherwise fail to build on Debian. Knoppix is
based on Debian testing+unstable.

I just uploaded the 0.9.12.0 compiz version based on
https://launchpad.net/compiz/+milestone/0.9.12.0, which features two
IMHO important accessibility patches (that I also attached here). They
fix the erraneous transparency on first usage of the ezoom and annotate
plugin (mouse curser and writing on screen were almost invisible unless
you activated the "magnify" plugin temporarily). I already suggested the
patches on the compiz bugtracker:
https://bugs.launchpad.net/compiz/+bug/1362005
https://bugs.launchpad.net/compiz/+bug/1362009
They have not been reviewed that, though.

Nevertheless, if you plan to adopt compiz in Debian again, I'd suggest
using the upstream sources on https://launchpad.net/compiz rather than
my modified version on
http://debian-knoppix.alioth.debian.org/packages/compiz and coordinate
with the project maintainers, which is just what Jean-Philippe Mengual
suggested.  Once compiz is officially back in Debian, I will happily use
that version rather than my forked version. I do need at least the ezoom
patch included in Knoppix, though, since ezoom (Super+Mousewheel) is an
important accessibility feature for users with low vision and is also
practival for presentations where the mousepointer should be visible.

Regards
-Klaus Knopper

On Tue, Sep 30, 2014 at 01:36:43AM +0200, MENGUAL Jean-Philippe wrote:
> Hi,
> 
> I'm going to package before freeze, on the top of 0.9.12 from
> Ubuntu. I don't have enough info about Knoppix packages
> (Debian-based, release, where they rely on, etc)..
> 
> I wonder if I should create from scratch in pkg-a11y group, or
> request for forwarding compiz from X to pkg-a11y before "updating"
> the git repo and so on.
> 
> I probably will go from scratch in pkg-a11y, if you have no problems
> with that.
> 
> Regards,
> 
> Le 13/09/2014 03:00, José Silva a écrit :
> >
> >Hello,
> >
> >> Please find the source & binary packaging here:
> >> http://debian-knoppix.alioth.debian.org/packages/compiz/
> >
> >There are only packages for knoppix i386.
> >
> >1. Could you please also package for amd64?
> >
> >2. My system is debian jessie/sid xfce4 amd64. Once your packages
> >are for debian/knoppix, will I be able to install your packages if
> >build to amd64?
> >
> >Regards,
> >jss
> 
> -- 
> Jean-Philippe MENGUAL
> 
> accelibreinfo, votre partenaire en informatique adaptée aux déficients visuels
> 
> Mail: texou@accelibreinfo.eu
> 
> Site Web: http://www.accelibreinfo.eu
=== modified file 'plugins/ezoom/src/ezoom.cpp'
--- plugins/ezoom/src/ezoom.cpp	2013-07-21 22:14:38 +0000
+++ plugins/ezoom/src/ezoom.cpp	2014-09-09 02:49:19 +0000
@@ -1164,6 +1164,7 @@
 	GLfloat        textureData[8];
 	GLfloat        vertexData[12];
 	GLVertexBuffer *streamingBuffer = GLVertexBuffer::streamingBuffer ();
+        const GLWindowPaintAttrib attrib = { OPAQUE, BRIGHT, COLOR, 0, 0, 0, 0 }; /* -KK */
 
 	sTransform.toScreenSpace (output, -DEFAULT_Z_CAMERA);
 	convertToZoomed (out, mouse.x (), mouse.y (), &ax, &ay);
@@ -1186,6 +1187,7 @@
 	glBindTexture (GL_TEXTURE_2D, cursor.texture);
 
 	streamingBuffer->begin (GL_TRIANGLE_STRIP);
+        streamingBuffer->colorDefault (); /* -KK */
 
 	vertexData[0]  = x;
 	vertexData[1]  = y;
@@ -1214,7 +1216,7 @@
 	streamingBuffer->addTexCoords (0, 4, textureData);
 
 	streamingBuffer->end ();
-	streamingBuffer->render (sTransform);
+	streamingBuffer->render (sTransform, attrib /* -KK */);
 
 	glBindTexture (GL_TEXTURE_2D, 0);
 	glDisable (GL_BLEND);
@@ -1743,6 +1745,7 @@
 		       CompAction::State  state,
 		       CompOption::Vector options)
 {
+
     zoomIn (action, state, options);
 
     if (state & CompAction::StateInitKey)
@@ -1753,6 +1756,7 @@
 
     toggleFunctions (true);
 
+
     return true;
 }
 

=== modified file 'plugins/annotate/src/annotate.cpp'
--- plugins/annotate/src/annotate.cpp	2013-07-19 03:04:12 +0000
+++ plugins/annotate/src/annotate.cpp	2014-09-09 03:35:33 +0000
@@ -615,6 +615,7 @@
     if (status)
     {
 	GLVertexBuffer *streamingBuffer = GLVertexBuffer::streamingBuffer ();
+        const GLWindowPaintAttrib attrib = { OPAQUE, BRIGHT, COLOR, 0, 0, 0, 0 }; /* -KK */
 	GLfloat         vertexData[18];
 	GLfloat         textureData[12];
 	CompRect        rect;
@@ -640,6 +641,7 @@
 		tex->enable (GLTexture::Fast);
 
 		streamingBuffer->begin (GL_TRIANGLES);
+		streamingBuffer->colorDefault (); /* -KK */
 
 		while (numRect--)
 		{
@@ -697,7 +699,7 @@
 		}
 
 		streamingBuffer->end ();
-		streamingBuffer->render (sTransform);
+		streamingBuffer->render (sTransform, attrib /* -KK */);
 
 		tex->disable ();
 	    }
@@ -710,6 +712,8 @@
 
 	    streamingBuffer->begin (GL_LINES);
 
+	    streamingBuffer->colorDefault (); /* -KK */
+
 	    streamingBuffer->addColors (1, optionGetStrokeColor ());
 
 	    vertexData[0] = initialPointerX;
@@ -721,7 +725,7 @@
 	    streamingBuffer->addVertices (2, vertexData);
 
 	    streamingBuffer->end ();
-	    streamingBuffer->render (sTransform);
+	    streamingBuffer->render (sTransform, attrib /* -KK */);
 	    break;
 
 	case RectangleMode:
@@ -741,11 +745,13 @@
 	    /* fill rectangle */
 	    streamingBuffer->begin (GL_TRIANGLE_STRIP);
 
+	    streamingBuffer->colorDefault (); /* -KK */
+
 	    streamingBuffer->addColors (1, optionGetFillColor ());
 	    streamingBuffer->addVertices (4, vertexData);
 
 	    streamingBuffer->end ();
-	    streamingBuffer->render (sTransform);
+	    streamingBuffer->render (sTransform, attrib /* -KK */);
 
 	    /* draw rectangle outline */
 	    vertexData[0]  = rectangle.x1 ();
@@ -765,11 +771,13 @@
 
 	    streamingBuffer->begin (GL_LINE_LOOP);
 
+	    streamingBuffer->colorDefault (); /* -KK */
+
 	    streamingBuffer->addColors (1, optionGetStrokeColor ());
 	    streamingBuffer->addVertices (4, vertexData);
 
 	    streamingBuffer->end ();
-	    streamingBuffer->render (sTransform);
+	    streamingBuffer->render (sTransform, attrib /* -KK */);
 
 	    break;
 
@@ -777,6 +785,8 @@
 	    /* fill ellipse */
 	    streamingBuffer->begin (GL_TRIANGLE_FAN);
 
+	    streamingBuffer->colorDefault (); /* -KK */
+
 	    streamingBuffer->addColors (1, optionGetFillColor ());
 
 	    vertexData[0] = ellipse.center.x ();
@@ -798,13 +808,15 @@
 	    streamingBuffer->addVertices (1, vertexData);
 
 	    streamingBuffer->end ();
-	    streamingBuffer->render (sTransform);
+	    streamingBuffer->render (sTransform, attrib /* -KK */);
 
 	    /* draw ellipse outline */
 	    glLineWidth (optionGetStrokeWidth ());
 
 	    streamingBuffer->begin (GL_TRIANGLE_STRIP);
 
+	    streamingBuffer->colorDefault (); /* -KK */
+
 	    streamingBuffer->addColors (1, optionGetStrokeColor ());
 
 
@@ -833,7 +845,7 @@
 	    streamingBuffer->addVertices (1, vertexData);
 
 	    streamingBuffer->end ();
-	    streamingBuffer->render (sTransform);
+	    streamingBuffer->render (sTransform, attrib /* -KK */);
 	    break;
 
 	default:


Reply to: