Bug#761152: Package review
Hi,
I had a look at your package from mentors, and here's a few comments.
debian/changelog:
Please replace your comment by "Initial release (Closes: #761152)." and
nothing else.
debian/control:
Please remove the X-Python-Version: and X-Python3-Version: fields. The
version referenced there are already in Wheezy, so there's no reason why
you would want to limit the Python version out of something that isn't
in Debian anymore (unless you want to backport to Lenny?).
The Vcs fields are wrong. They exist to reference the *packaging* VCS
URLs, not the upstream one. If you want to package stuff using Git, then
I would strongly recommend that you do so within the "Debian Python
Module Team". We do accept Git packaging now, after we discussed that at
last Debconf.
You don't need to write debhelper (>= 9.0.0), simply debhelper (>= 9) is
enough, please fix that.
The dependency to python-all should be: python-all (>= 2.6.6-3~). This
is explained here: https://wiki.debian.org/Python/TransitionToDHPython2
debian/copyright:
Please add the copyright notice for the GPL-3. Just referencing the
/usr/share/common-licenses isn't enough. Feel free to have a look into
any package in Debian that uses the parse-able copyright format and the
GPL-3 (there's loads of example). The way you did, it's going to simply
be rejected by the FTP masters.
Everything else is ok to me. Please fix the above, and I'll sponsor your
package in Debian.
Cheers,
Thomas Goirand (zigo)
Reply to: