Bug#535073: ITP: dolphin-emu -- Dolphin Gamecube / Wii Emulator
Hi,
This looks really interesting and I'd love to see it in Debian. Have you
found a sponsor yet? I'm not a DD so I can't sponsor packages but if you
need a sponsor you could ask the Debian Games Team[1] and co-maintain it
with them.
I've also reviewed the package you uploaded to mentors.
[1] https://wiki.debian.org/Games
pkg-games-devel@lists.alioth.debian.org
James
--------------------------
docs/*
- This stuff looks like developer documentation rather than user documentation,
does it need to be shipped at all?
- Is WiiMote/HID_SPEC_V10.rar freely distributable?
- DSP/GC_DSP.pdf should be in debian/copyright
source for binaries
- Debian requires that if you ship binaries, you must also ship their "source"
(preferred form of modification)
- Remove the android support library
Source/Android/libs/android-support-v13.jar
- I'm concerned about these binaries.
Where are they from? Are they freely distributable?
Data/Sys/GC/dsp_coef.bin
Data/Sys/GC/dsp_rom.bin
Data/Sys/GC/font_ansi.bin
Data/Sys/GC/font_sjis.bin
Data/Sys/Wii/shared2/sys/SYSCONF
Data/Sys/Wii/shared2/wc24/mbox/wc24recv.ctl
Data/Sys/Wii/shared2/wc24/mbox/wc24recv.mbx
Data/Sys/Wii/shared2/wc24/mbox/wc24send.ctl
Data/Sys/Wii/shared2/wc24/mbox/wc24send.mbx
Data/Sys/Wii/shared2/wc24/misc.bin
Data/Sys/Wii/shared2/wc24/nwc24dl.bin
Data/Sys/Wii/shared2/wc24/nwc24fl.bin
Data/Sys/Wii/shared2/wc24/nwc24fls.bin
Data/Sys/Wii/shared2/wc24/nwc24msg.cbk
Data/Sys/Wii/shared2/wc24/nwc24msg.cfg
Data/Sys/codehandler.bin
Data/Sys/totaldb.dsy
debian/changelog
- Squash all the changelog entries into one for "4.0.2-1"
- You write "Deleted several directories and files from Externals. Most were
unused and some were non-free." in the first changelog entry. If you did
remove some files for this reason, the package should have a version with
dfsg in it like "4.0.2+dfsg-1"
debian/copyright
W: dolphin-emu source: empty-short-license-in-dep5-copyright (paragraph at line 11)
W: dolphin-emu source: empty-short-license-in-dep5-copyright (paragraph at line 105)
W: dolphin-emu source: empty-short-license-in-dep5-copyright (paragraph at line 269)
W: dolphin-emu source: space-in-std-shortname-in-dep5-copyright gpl-2 and bsd-3-clause (paragraph at line 130)
I: dolphin-emu source: wildcard-matches-nothing-in-dep5-copyright (paragraph at line 44)
I: dolphin-emu source: wildcard-matches-nothing-in-dep5-copyright (paragraph at line 183)
I: dolphin-emu source: wildcard-matches-nothing-in-dep5-copyright (paragraph at line 194)
I: dolphin-emu source: wildcard-matches-nothing-in-dep5-copyright (paragraph at line 211)
I: dolphin-emu source: wildcard-matches-nothing-in-dep5-copyright (paragraph at line 261)
I: dolphin-emu source: wildcard-matches-nothing-in-dep5-copyright (paragraph at line 269)
debian/control
- libminiupnpc-dev is now version 1.9.20140610-2 in unstable
- Remove non-existant libwxgtk2.9-dev dependency
- Update to standards 3.9.5
- The dependency on dolphin-emu-data will match ANY version - is this what you want?
If you want the data to be the same upstream version as the main package, use:
dolphin-emu-data (<= ${source:Version}), dolphin-emu-data (>= ${source:Upstream-Version})
- IMHO the first line of the description should match with all of the packages like:
Gamecube, Wii and Triforce emulator
Gamecube, Wii and Triforce emulator - data files
Gamecube, Wii and Triforce emulator - documentation
debian/*.install
- If the source directory matches the destination, you can omit it
usr/share/games/dolphin-emu/*
instead of
usr/share/games/dolphin-emu/* usr/share/games/dolphin-emu
See dh_install(1)
debian/rules
- Remove pointless "export DH_OPTIONS"
- Update get-orig-source to use github
Not required, but I quite like this for removing extra files from the upstream source
https://wiki.debian.org/UscanEnhancements
- The buildflags stuff shouldn't be needed - it's done by debhelper for you
- Parsing the changelog for "GIT Release" is really dodgy. I can imagine this
breaking when anyone does a NMU / minor change for instance.
- Do you even need to record the git version? We already have the release
version and the developers can work out a git hash from that anyway.
- Enable hardening flags if they don't break the build
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
debian/watch
version=3
opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/dolphin-$1\.tar\.gz/ \
https://github.com/dolphin-emu/dolphin/tags .*/v?(\d\S*)\.tar\.gz
debian/patches/*
- (just a reminder) Any non-debian patches should be submitted upstream as well as included here.
eg as the sfml maintainer it's a bit sad that upstream still use and bundle a version from 5 years ago
debian/patches/05_default-optimizations.patch
- Patch is not in series file (remove or use it)
debian/patches/40_disable-upnp.patch
- "as it requires linking against libupnpc version newer than in Debian Experimental" is it available now?
debian/patches/41_miniupnpc-lower-version.patch
- Newer version in unstable now (1.9)
debian/patches/50_glew-lower-version.patch
- Newer version in unstable now (1.10)
Reply to: