[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754287: (no subject)

Hello Riley,

Thanks for taking the time to give this another review! These
corrections have helped me understand further what needs to be done to
get a package ready for Debian :) I have the request for a sponsor out,
so will update that package with these changes as well.


Yes, you can keep your releases on the GitHub branch.
However, it would be advisable to remove the /debian directory from your
github repository. Even though you may be maintaining both upstream and
with Debian, this may change in the future, and it causes problems if
upstream and Debian have different /debian directories. (Also, it
becomes more difficult to generate the .orig.tar.gz )
** I see what you mean. It was testing pulling from GitHub, and making
the .orig.tar.gz was a pain. So I will drop it from GitHub, as bug fixes
should not affect this.

*You mentioned that you were using debhelper 9, so you should change
d/compat to 9. (This will also fix the
"missing-dependency-on-python-support" lintian tag.)
** I have updated to 9 in this file, and fixed this issue!

*The full text of CC-0 formatted for d/copyright can be found here [1]
**Thanks, cound not find this full one!

*python-setuptools is required to build, but build-depends lists
python3-setuptools. It appears that this is because some parts of the
d/rules are using python2.7 by default. I've managed to build it without
python-setuptools by making the following modifications:
 -In line 10, replace "python setup.py" with "python3 setup.py"
 -Add a line "override_dh_auto_configure:"
** Awesome, this was giving me a headache, but this fixed the Dependency
on Python2. I read in the docs all new packages needed to used Python3,
so this corrects the issue!

*You include several lib/ entries in the copyright file, but you do not
distribute them. It is good that you do not distribute them (because
modules should be packaged separately), but these should be removed
from the d/copyright.
** I see, I was not sure about whether or not they should be included,
so I added them in just in case. I will go ahead and remove them now.

*I couldn't find packages for the tzlocal and Delorean modules. These
will have to be packaged first, then added as dependencies. The Python
Modules Team [2] should be able to help you with this.
** Thanks for the link. I will drop this team a line and see if they can
help me out.

*I think that you've got the license GNU right, but I'm not sure. Read
over this IRC log [4] and note that the icon was originally from here
[5] and then make a decision for yourself.
** Hmmm, this is a tuff one. It would probably be safe to update, but I
have a feeling that it would be ok to keep it as GNU, as that is what it
was submitted at the time. If this needs to be updated, should be simple

Thanks again, and please let me know if there is anything I can help with.

- Dave

Reply to: