[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754287: (no subject)



I have completed the corrections based on the review. Changes have been
comitted and pushed to GitHub.

https://github.com/DMaiorino/tz-converter

In order to publish in the Debian repo, can I keep the releases on this
branch? If there is anything else I need to do, please let me know.

I have added a response to the comments below:

General:
-You need to write a manpage
*Added one in!
-Add a watch file
* Cool, did not know about this! Added one now.
-Is tz-converter really a native package?
* No, it is not. Changed this to use quilt
-Add a homepage field
* Added homepage link.
-Stop depending on the python-support package; use dh_python2
* Had both in the Build-Depends, dropped python-support.

d/changelog:
-Add the phrase "Initial release (closes: #754287)".
* Corrected with phrase "Initial release (closes: #754287)".
-Don't use the Ubuntu name "trusty". Continue to use Debian's "unstable"
* Added "unstable" to changelog.

d/control:
-Fix up the spacing on line 11
* Deleted extra space
-Add a version for the build-depends of debhelper (it appears that you
are using version 7, so you'd use "debhelper (>= 7)"
* Updated version to "debhelper (>= 9)"

d/patches:
-This is not necessary since you do not have any patches
Was trying out patched. Removed this now.

d/copyright:
-You say that the license for your files is GPL-3+. Looking at the
github source, I can't find any indication that this is the case.
Perhaps you could add a notice and a copy of the license in the root
directory/as headers on your source files?
*Thought I added that, sorry for leaving it out. Added GPL-3+ to the
root of the repo.
-You have not given the full text of CC-0.
* I have added the bullets that were at the bottom of this info. I am
not sure of the full text, but and using the following link:
http://creativecommons.org/publicdomain/zero/1.0/
-You list icons/Saki-NuoveXT-Apps-world-clock.ico as having the license
"GNU", but you do not give the text of the license.
* Added GNU to the copyright.


Reply to: