On Sun, Feb 23, 2014 at 10:58:07PM +0100, Raúl Sánchez Siles wrote:
> Hi All:
>
> El Domingo, 23 de febrero de 2014 12:01:30 Bartosz Feński escribió:
> > Hi Raul,
> >
> > Did you fix problems mentioned by Alessandro?
> > Are you still working on libsodium?
> >
> > I need this library to package tox.im for Debian.
> >
> > regards,
> > fEnIo
>
> I've just noticed about Alessandro comments. Unfortunately I overlooked
> them. Sorry about this.
No problem.
> I've updated the packaging, based on upstream git snapshot. I didn't try
> harder for an upload for 0.4.5 since package and packaging was not ready for
> multi-arch. Recent git snapshots finally cope with multi-arch so I'm awaiting
> for a release.
Ok.
> I've addressed most of the points Alessandro made. His comments were based
> on an old packaging version, so I already had fixed them. Copyright file is
> still not ready but I plan to fix it this week. Also removing autotools-dev b-p
> throws a lintian error and I've readded it.
What error? Note that you also have to remove "autotools-dev" from the dh
command in debian/rules.
Also, automake, autoconf and libtool build deps aren't needed either since thay
are pulled in by dh-autoreconf (and AFAICT you are not using them directly).
See attached patch for example.
Another nitpick, since you are using mercurial to maintain the package, you
may want to populate the Vcs-* headers in debian/control as well (and ideally
move the repository to Debian's alioth service [0] [1]).
Cheers
[0] https://wiki.debian.org/Alioth/PackagingProject
[1] https://wiki.debian.org/Alioth/Hg
--
perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
From 24a19783319ab8e515bd5a8efc4bf33695a0eea9 Mon Sep 17 00:00:00 2001 From: Alessandro Ghedini <alessandro@ghedini.me> Date: Sun, 23 Feb 2014 23:14:28 +0100 Subject: [PATCH] Do not use autotools-dev --- debian/control | 3 +-- debian/rules | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/debian/control b/debian/control index 2c75c14..41d702d 100644 --- a/debian/control +++ b/debian/control @@ -2,8 +2,7 @@ Source: libsodium Section: libs Priority: optional Maintainer: Raúl Sánchez Siles <rasasi78@gmail.com> -Build-Depends: debhelper ( >= 9), automake ( >= 1:1.11 ), autotools-dev, - pkg-config, autoconf, libtool, dh-autoreconf +Build-Depends: debhelper ( >= 9), pkg-config, dh-autoreconf Standards-Version: 3.9.5 #Vcs-hg: #Vcs-browser: diff --git a/debian/rules b/debian/rules index ae1a547..78e90a7 100755 --- a/debian/rules +++ b/debian/rules @@ -1,7 +1,7 @@ #!/usr/bin/make -f %: - dh $@ --with autotools-dev,autoreconf -Bbuild + dh $@ --with=autoreconf -Bbuild override_dh_strip: dh_strip --dbg-package=libsodium-dbg -- 1.9.0
Attachment:
signature.asc
Description: Digital signature