On 14/07/13 08:12, heroxbd wrote: > Hi Ximin, > > Ximin Luo <infinity0@gmx.com> writes: > >> Sorry, ignore this, I missed the fact that scim and scim-pinyin are separate >> upstream packages. Your versioning is fine. > > Okay. > >>> 2. Please upload your PGP key 0xDFBE5F8B into the public keyservers. Otherwise >>> I cannot verify your signature. > > Thanks. I'll do that later. > >>> Also note that I do not have Debian Developer / Maintainer access, so we will >>> need to find someone else to sponsor your package. But I can do a >>> code review. >> >> I have tested your package and it works well. Thanks! I looked over your >> changes to debian/** and everything looks good - especially that you simplified >> debian/rules and formatted debian/copyright correctly. It's definitely a >> significant improvement and follows the Debian standards well. :) >> >> I'll try to get a DD/DM to sponsor this over the coming days. > > I have joined pkg-ime team[1] and received sponsorship from > Osasu-san. The package is already in the upload queue[2]. However not > processed by ftp-masters for more than a month. > > I'll ping ftp-masters for it. > It would appear the version in the upload queue is not the same as the one currently in mentors, which is what I reviewed. For example, the md5sums on that [2] link disagree with the one from mentors, which is 71ab727af0d37eabfa17aa45be2ead1e scim-pinyin_0.5.92.orig.tar.gz 5b957ad2f37199b7c2a90f5c778b8dd0 scim-pinyin_0.5.92-1_amd64.deb 0b74218d350d1095e86016ae550e19d4 scim-pinyin_0.5.92-1.debian.tar.gz 3fe57260220abec3e5d66b48cd0c4792 scim-pinyin_0.5.92-1.dsc Some more obvious changes: - the debian/copyright file in the upload queue is still in the old format. - there are lintian warnings; there are no warnings for the mentors version I'd suggest you cancel the one in the current queue (if that's possible) and have your sponsors upload from mentors directly. > Cheers, > Benda > > 1. https://alioth.debian.org/projects/pkg-ime/ > 2. http://ftp-master.debian.org/new/scim-pinyin_0.5.92-1.html > -- GPG: 4096R/5FBBDBCE https://github.com/infinity0 https://bitbucket.org/infinity0 https://launchpad.net/~infinity0
Attachment:
signature.asc
Description: OpenPGP digital signature