On 16/03/13 02:32, Laszlo Boszormenyi (GCS) wrote:
> Sure, it looks OK. Still, there's some things to fix. Why do you use
> Java 6? Java 7 is in Debian now, see the openjdk-7-jre package.
Changed.
> Copyright format is now official, please use its format line[1].
> BSD-2 license text lines are too long, please use a 80 chars width one.
Changed.
> It would be nice to 'beautify' debian/rules . The second line can show
> the file format if set to: '# -*- makefile -*-'. Override targets should
> be listed in the '.PHONY: ...' line at the end.
Changed. GNU Make manual suggests this should be before the definition
though...[1]
> The debian/watch is essentially empty, delete it or make use of it.
If you don't have a debian/watch lintian will tell you to either add
one, or add one with just comments explaining the situation.
> Worst is that JMapViewer_Demo.jar is empty, contains only MANIFEST.MF .
> Is it an upstream build problem?
Yes I noticed that lintian warning. I'm pretty sure this is how upstream
does it. If this is a problem, in the Debian package we can ignore the
upstream JMapViewer_Demo.jar and simply change our /usr/bin/jmapviewer
script to
java -Djava.net.useSystemProxies=true -cp
/usr/share/java/jmapviewer.jar org.openstreetmap.gui.jmapviewer.Demo "$@"
Is this a better approach? It is a pretty easy change to make.
[1] https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
Attachment:
signature.asc
Description: OpenPGP digital signature