[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#724801: ITP: yt -- yt is a command-line front-end to YouTube



Hello Dominik, 

You're awesome!, I've applied most of your changes:

- Do not use only the date for your package version!
   - I've applied your scheme, update it to bee8fd44c0

- omxplayer is not in Debian, so do not install the pi-yt script.
   - Applied

- Install docs; NEWS.txt is renamed to CHANGELOG.txt to satisfy lintian.
   - Applied

- Remove whitey egg-info.
   - Applied

- Do not just tar up a git clone to create an orig tgz! Use a proper
  get-orig-source that repackages a Github snapshot. Once this is done,
  you jsut need to do this to create a new orig tgz, even for a new
  upstream version:
   dch -i # insert proper new upstream version, we cannot use uscan
          # here because we cannot really monitor upstream commits
   debian/rules get-orig-source # drops yt_<UPSTREAM-VERSION>.orig.tar.xz
                                # in current directory
   # unpack and move your Debian directory
   # or use git-buildpackage

   - I had no idea how to this, I've learned and applied your changes

- As setup.py clearly states Apache 2.0, putthat dual license choice in
  debian/copyright.
    - Applied

- I added myself to debian/copyright for the rules file, and to Uploaders
  to justify the changelog entry. If you incorporate the changes and udpate
  the changelog yourself, you can remvoe Uploaders if you want.
    - Applied

 - I'd also upgrade the Recommends to Depends. I do not see what use your
ackage could be without youtube-dl and mplayer. I'd also change it to:
   Depends: youtube-dl, mplayer2 | mplayer

    - I've added mplayer2|mplayer to Depends, youtube-dl is still as Recommends
      the reason for this is that I've seen a lot of people downloading the youtube-dl
      script directly (including me), and I don't want to force them to use the debian
      youtube-dl package instead of his. People installing youtube-cli with the 
      --no-install-recommends option then can use his own youtube-dl version

- Attached is a patch that renames all relevant parts to youtube-cli
    - Applied

I've decided to keep README.source, it makes no harm and I've an awful memory, if I
don't write this down, I'll forget it. I'm still not very experimented with debian
packaging.

It still has missing the watch file, I'll keep a look at upstream to see if at some point
he decides to use tags, then I'll be able to create a watch file.

Best regards


Reply to: