[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#714179: [pkg-php-pear] ITP: php-json-schema -- PHP implementation of JSON schema



On 06/28/2013 04:43 AM, andrea rota wrote:
> Thomas, Prach,
> thanks for your advice:
> 
> On Thu, Jun 27, 2013 at 11:53:17AM +0800, Thomas Goirand wrote:
> [...]
>> zigo@d(ebian-sid)>_
>> ~/sources/pkg-php-pear/php-json-schema/php-json-schema$ git-buildpackage
>> dh clean --with phpcomposer
>>    dh_testdir
>>    dh_auto_clean
>>    dh_clean
>> gbp:error: upstream/1.3.2 is not a valid treeish
>>
>> Are you using pristine-tar? If so, please push that branch, edit
>> debian/gbp.conf to add the pristine-tar = True, and push all tags.
> 
> good point. i was starting directly from upstream's git, but have now
> updated the workflow to use both upstream git *and* pristine-tar as per
> http://www.eyrie.org/~eagle/journal/2013-04/001.html - tried on a fresh
> sid install and this now builds correctly for me there.
> 
> [...]
> 
> On Thu, Jun 27, 2013 at 02:01:06PM +0700, Prach Pongpanich wrote:
> [...]
>> Hi Andrea,
>>
>> I hope this help for creating a new git repository.
>> [...]
> 
> this tutorial is great! is it available online somewhere?! otherwise,
> it'd be great to have it added somewhere under
> http://wiki.debian.org/PHP/ for developers starting collaborating on
> pkg-php packages.
> 
> thanks
> andrea

Same remarks as for the other package: your package is missing the
${phppear:Debian-Depends}, ${phppear:Debian-Recommends} and
${phppear:Debian-Breaks} (read man dh_phppear), and therefore, it is
missing some important dependencies (like php-pear for example).

Do not forget that a package which is --with phpcomposer is also a pear
package, so I believe (I never tried, but I think so) you should use:

dh $@ --buildsystem=phppear --with phppear,phpcomposer

in your rules file. Mathieu, can you confirm that this is the way to do
(since that's new features)?

Thomas Goirand (zigo)


Reply to: