Bug#693481: python-webm: support for loseless mode
On Sat, 22 Jun 2013 20:41:06 Antoine Martin wrote:
> Note: upstream python-webm has not received a single update since March
> 2012, and it is now behind our in-tree copy which now supports lossless
> compression.
So true and there were no response for bugs either... Anyway it would
be easier to maintain "python-webm" as standalone package at least for
the sake of running post build-tests...
> I have created an upstream ticket with my patch:
> https://code.google.com/p/python-webm/issues/detail?id=2
Awesome, I'll incorporate it to the package. Thanks for letting me
know. I also converted your improvements to patch and attached to
upstream ticket. Could you also add some unit tests please?
> As for the hard-coded library names, this is unfortunate but was needed
> to make it work on all the platforms we support (I can't remember for
> sure, but I think "find_library" did not work on OSX for example). We
> *could* use "find_library" once it has been proven to work everywhere
> (takes time).
I'm glad that in Debian we don't have such constraint...
> Please also note that in the upcoming xpra 0.10 release, the loading of
> codecs has changed: we now use the __import__ construct to "soft load"
> these dependencies. Your patches will need to get updated for that.
I'm not sure if I understand what do you mean... Please remember that
you're talking to python illiterate so I apologise if occasionally you
need to talk to me like if you're speaking to baby to be
understood... :)
Your patches are always welcome of course.
> Also, in Debian speak this means "libwebp" should be a "Suggests" or at
> most a "Recommends" rather than a hard dependency.
Of course. I already tested Xpra and found that it works perfectly
with absence of python-webm. I think I'll make it Recommends.
At the moment I also need to patch Xpra to use system (not bundled)
python-webm...
Regards,
Dmitry Smirnov.
---
I hate all sports as rabidly as a person who likes sports hates common
sense.
-- H. L. Mencken
Reply to: