[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#651944: Feedback on the (unreleased) package



Am Saturday, 23. March 2013 schrieben Sie:

> > - after that finished, I found a /etc/apache2/conf.d/friendica.conf,
> > which I replaced with the apache2.subdomain.conf from the doc examples
> > directory
> 
> I see did the friendica.conf didn't work? Did you face some error?

No, no error (except for the whitespace in the accept/deny config). AFAIR, it 
contained some comment like "replace this with an appropriate config from 
/usr/share/doc/friendica/examples or something like that. So I had a look and 
found that one more appropriate for my setup. 

> > - the web interface was available, but it showed the installer (is that
> > supposed to happen?)
> 
> Yeah for now it should get you installer. I'm not sure if that can be
> automated may be friendica devs can answer (hint hint Tobias)

AFAIU, it wouldn't show the installer if the generated htconfig.php would have 
been copied to /usr/share/friendica/.htconfig.php (after the database tables 
had been successfully created). Maybe that would even have happened.

> > - installer complained about /usr/share/friendica/.htaccess not being
> > available and not creatable either, so I created the file and made it
> > writable
> 
> Weird I think I fixed in the last week upload to mentors! Did you try
> this with which package?

Ahh, I see the problem now. I did get the package on March 19th (UTC+1)
dget -x 
http://mentors.debian.net/debian/pool/main/f/friendica/friendica_3.1-1.dsc

Your new package was apparently made public a little later, even though it was 
uploaded on March 17th. At least I get a different dsc file, when I download it 
again, now (same version number).
 
So the version I have installed now, is probably 3.1-1 from 2013-01-13 05:19

All those problems that you thought you had fixed, can probably be attributed 
to that.

> > - I manually created the database with /usr/share/friendica/database.sql
> > and finally got friendica up and running
> 
> Uh was the database.sql was missing in installation? I'm not sure what
> might have gone wrong.

No, it was there, but somehow it wasn't applied. After I did this manually, 
the Apache crashes were gone.

> > Then online help didn't work at all (internal server error), I had to
> > remove the symlink /usr/share/friendica/library/markdown.php and replace
> > it with the PHP Markdown Extra "markdown.php" from
> > http://littoral.michelf.ca/code/php-
> > markdown/php-markdown-extra-1.2.6.zip
> 
> The markdown.php on squeeze that might be the reason. I'm not planning
> to target friendica to squeeze as it will be soon old stable.

That was my first thought as well, but I learnt that there are two different 
distributions of that markdown parser. One with an "ExtraParser" class and one 
without.  Debian (both stable and newer versions) packages the one without the 
ExtraParser.

BTW, I found another problem, but I probably need to check whether that's fixed 
with the newer version: the cronjob (poller.php) always reports warnings like

PHP Warning:  Invalid argument supplied for foreach() in 
/usr/share/friendica/include/config.php on line 23
PHP Warning:  Invalid argument supplied for foreach() in 
/usr/share/friendica/include/config.php on line 23
PHP Warning:  Invalid argument supplied for foreach() in 
/usr/share/friendica/include/plugin.php on line 150
PHP Warning:  Invalid argument supplied for foreach() in 
/usr/share/friendica/include/datetime.php on line 456
PHP Warning:  Invalid argument supplied for foreach() in 
/usr/share/friendica/include/socgraph.php on line 357
PHP Warning:  Invalid argument supplied for foreach() in 
/usr/share/friendica/include/poller.php on line 168

(and many more). That's not the fault in the package, but a problem in 
friendica itself. The function q() either returns an array (good) or false 
when something is wrong. Callers of the function only check the result with 
count() and then iterate over it with foreach (which fails when trying to 
iterate over 'false'). All these places would need to be changed to something 
like 
if (is_array($r) && count($r)

Without that, you would get a mail from cron every 10 minutes by default...

> Wonderful! Thank you for taking time to share the problems you faced. I
> will see how I can fix these

Thank you so much for working on the package. Getting such things easily 
installable is why I love Debian :-)

Thanks again,
Carsten


Reply to: