On 25.08.2012 06:36, Rodolfo Granata wrote:
> Hi Thanks for taking the time on wbar, please read inline.
Hi,
thank you for your quick reply. I think you've answered all of my
questions which helps me a lot. It's great to know that the non-free
icons are gone which means now i can work on your official tarball
without having to repack it.
We are almost finished, let me suggest the following though.
==Official Tarball==
It's really polished now. But you can safely remove the debian directory
because technically speaking it doesn't belong to the original sources.
I suggest you simply remove it and i will take care of all Debian
related stuff. Then you could rename your next source tarball for
example to wbar-2.3.2.tgz and everyone would be happy.
==make-conf.sh==
Great idea. Having a convenient script which takes care of creating a
default config is very useful. Maybe we should extend the search for
icons a bit because quite a lot of applications store their icons in
/usr/share/pixmaps. At the moment this directory is excluded and not
every application uses hicolor icons. I also think it should be
installed in /usr/share/wbar/.
==wbar.cfg==
I have attached a patch which creates a sane default wbar.cfg. It
contains two config blocks. For the first one i've changed
osxbarback.png to dock.png. I think it is better to set the font to
"none" because as far as i know there is no reliable way to know which
fonts are installed. Most of them will have something like
ttf-liberation or ttf-dejavu installed on their system, but we can't be
100% sure.
Therefore i think it would be better to refrain from using a specific
font because it is very likely that wbar will refuse to start on a
system without the font which could be a real show-stopper for novice
users. Let the user decide which font he wants to use.
The second block in wbar.cfg points to wbar-config which should be a
default entry in wbar. But i guess we need the wbar.png file back. I
thought this one was free and you or yadickson had created it. If i'm
wrong will you consider to replace it with a free icon? Thus it could be
used not only in wbar itself but also in desktop menus.
==wbar.desktop==
I've attached another patch which changes the icon path to
/usr/share/pixmaps/wbar/wbar.png. It would be ideal if the desktop file
was located in the /share directory because normally desktop files
belong here. If you don't want to change the location, i could also
override the installation path in the debian directory.
==README==
I think we should mention wbar-config and make-conf.sh in the README,
too and promote them.
==My summary==
To create a sane default we should
- set no specific font path
- use wbar.png as the default icon in wbar which points the user to
wbar-config
- promote wbar-config and make-config.sh in the README file
Thanks again and keep up the good work.
Cheers
Markus
--- a/etc/wbar.cfg.in +++ b/etc/wbar.cfg.in @@ -1,4 +1,4 @@ -i: @PIXMAPDIR@/@PACKAGE_NAME@/osxbarback.png +i: @PIXMAPDIR@/@PACKAGE_NAME@/dock.png c: @PACKAGE_NAME@ @DEFAULT_ARGV@ t: none @@ -6,31 +6,4 @@ i: @PIXMAPDIR@/@PACKAGE_NAME@/wbar.png c: wbar-config t: Config -i: @PIXMAPDIR@/@PACKAGE_NAME@/pidgin.png -c: pidgin -t: Pidgin - -i: @PIXMAPDIR@/@PACKAGE_NAME@/anjuta.png -c: anjuta -t: Anjuta - -i: @PIXMAPDIR@/@PACKAGE_NAME@/bluefish.png -c: bluefish -t: Bluefish - -i: @PIXMAPDIR@/@PACKAGE_NAME@/gimp.png -c: gimp -t: Gimp - -i: @PIXMAPDIR@/@PACKAGE_NAME@/ooffice.png -c: ooffice -t: OOffice - -i: @PIXMAPDIR@/@PACKAGE_NAME@/synaptic.png -c: su-to-root -X -c /usr/sbin/synaptic -t: Synaptic - -i: @PIXMAPDIR@/@PACKAGE_NAME@/terminal.png -c: gnome-terminal -t: Terminal
--- a/etc/wbar.desktop.in.in +++ b/etc/wbar.desktop.in.in @@ -3,7 +3,7 @@ _Name=Warlock Bar Type=Application Exec=@BINDIR@/@PACKAGE_NAME@ Terminal=false -Icon=@PIXMAPDIR@/@PACKAGE_NAME@.png +Icon=@PIXMAPDIR@/@PACKAGE_NAME@/@PACKAGE_NAME@.png _Comment=A light and fast launch bar. Categories=Utility; X-GNOME-Bugzilla-Bugzilla=GNOME
Attachment:
signature.asc
Description: OpenPGP digital signature