[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#654924: Alioth Projekt genehmigt



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 06.04.2012 18:38, schrieb Mike Gabriel:
> Hi Joachim, Yaroslav,
>
> On Fr 06 Apr 2012 16:16:13 CEST Joachim Falk wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Am 04.04.2012 02:34, schrieb Yaroslav Halchenko:
>>> awesome!
>>>
>>> would you mind opening up read-only access to the "world"?
>> Should be open. You can also use
>>   git clone http://xiao.jfalk.de/~joachim/tigervnc/tigervnc.git
>> It should have the same version as the alioth git repo.
>>
>> Between, I have updated to tigervnc 1.2.0.
>
> I have tested latest stuff in Git, please do a pull on master branch on
> Alioth, I have committed some build-deps.
>
> However, build fails (on squeeze _and_ sid)... See below...
>
> Any ideas?
Yes. You have a more paranoid build environment than me, i.e., -Wformat
- -Wformat-security -Werror=format-security.
And the compiler caught a security violation. Format string is not
constant but some (maybe user) input.

  } catch (rdr::Exception& e) {
    vlog.error(e.str());
    fl_alert(e.str());
    exit_vncviewer();
    return;
  }

http://www.fltk.org/doc-1.3/group__group__comdlg.html

fl_alert(e.str()); => fl_alert("%s", e.str()); <= that should work

>
> Mike
>
> <quote>
> [ 96%] Built target translations
> /usr/bin/make -f vncviewer/CMakeFiles/vncviewer.dir/build.make
> vncviewer/CMakeFiles/vncviewer.dir/depend
> make[3]: Entering directory
> `/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu'
> cd /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu && /usr/bin/cmake -E
> cmake_depends "Unix Makefiles" /home/mike/tmp/tigervnc.b/tigervnc
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer
> /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu
> /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/vncviewer
> /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/vncviewer/CMakeFiles/vncviewer.dir/DependInfo.cmake
> --color=
> Scanning dependencies of target vncviewer
> make[3]: Leaving directory `/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu'
> /usr/bin/make -f vncviewer/CMakeFiles/vncviewer.dir/build.make
> vncviewer/CMakeFiles/vncviewer.dir/build
> make[3]: Entering directory
> `/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu'
> /usr/bin/cmake -E cmake_progress_report
> /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/CMakeFiles
> [ 96%] Building CXX object
> vncviewer/CMakeFiles/vncviewer.dir/buildTime.cxx.o
> cd /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/vncviewer &&
> /usr/bin/g++   -DPACKAGE_NAME=\"tigervnc\" -DPACKAGE_VERSION=\"1.2.0\"
> -DLOCALEDIR=\"/usr/share/locale\" -D__BUILD__=\"20120406\" -DHAVE_GNUTLS
> -DHAVE_CONFIG_H -g -O2 -fstack-protector --param=ssp-buffer-size=4
> -Wformat -Wformat-security -Werror=format-security -Wall -O3 -DNDEBUG
> -I/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu
> -I/home/mike/tmp/tigervnc.b/tigervnc/common/fltk
> -I/home/mike/tmp/tigervnc.b/tigervnc/common    -o
> CMakeFiles/vncviewer.dir/buildTime.cxx.o -c
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/buildTime.cxx
> /usr/bin/cmake -E cmake_progress_report
> /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/CMakeFiles 93
> [ 97%] Building CXX object vncviewer/CMakeFiles/vncviewer.dir/menukey.cxx.o
> cd /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/vncviewer &&
> /usr/bin/g++   -DPACKAGE_NAME=\"tigervnc\" -DPACKAGE_VERSION=\"1.2.0\"
> -DLOCALEDIR=\"/usr/share/locale\" -D__BUILD__=\"20120406\" -DHAVE_GNUTLS
> -DHAVE_CONFIG_H -g -O2 -fstack-protector --param=ssp-buffer-size=4
> -Wformat -Wformat-security -Werror=format-security -Wall -O3 -DNDEBUG
> -I/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu
> -I/home/mike/tmp/tigervnc.b/tigervnc/common/fltk
> -I/home/mike/tmp/tigervnc.b/tigervnc/common    -o
> CMakeFiles/vncviewer.dir/menukey.cxx.o -c
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/menukey.cxx
> /usr/bin/cmake -E cmake_progress_report
> /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/CMakeFiles
> [ 97%] Building CXX object vncviewer/CMakeFiles/vncviewer.dir/CConn.cxx.o
> cd /home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu/vncviewer &&
> /usr/bin/g++   -DPACKAGE_NAME=\"tigervnc\" -DPACKAGE_VERSION=\"1.2.0\"
> -DLOCALEDIR=\"/usr/share/locale\" -D__BUILD__=\"20120406\" -DHAVE_GNUTLS
> -DHAVE_CONFIG_H -g -O2 -fstack-protector --param=ssp-buffer-size=4
> -Wformat -Wformat-security -Werror=format-security -Wall -O3 -DNDEBUG
> -I/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu
> -I/home/mike/tmp/tigervnc.b/tigervnc/common/fltk
> -I/home/mike/tmp/tigervnc.b/tigervnc/common    -o
> CMakeFiles/vncviewer.dir/CConn.cxx.o -c
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/CConn.cxx
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/CConn.cxx: In constructor
> ?CConn::CConn(const char*)?:
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/CConn.cxx:103:21: error:
> format not a string literal and no format arguments
> [-Werror=format-security]
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/CConn.cxx: In member
> function ?virtual void CConn::setExtendedDesktopSize(int, int, int, int,
> const rfb::ScreenSet&)?:
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/CConn.cxx:270:18: warning:
> comparison between signed and unsigned integer expressions [-Wsign-compare]
> /home/mike/tmp/tigervnc.b/tigervnc/vncviewer/CConn.cxx:270:46: warning:
> comparison between signed and unsigned integer expressions [-Wsign-compare]
> cc1plus: some warnings being treated as errors
> make[3]: *** [vncviewer/CMakeFiles/vncviewer.dir/CConn.cxx.o] Fehler 1
> make[3]: Leaving directory `/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu'
> make[2]: *** [vncviewer/CMakeFiles/vncviewer.dir/all] Fehler 2
> make[2]: Leaving directory `/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu'
> make[1]: *** [all] Fehler 2
> make[1]: Leaving directory `/home/mike/tmp/tigervnc.b/obj-x86_64-linux-gnu'
> make: *** [debian/stamp-makefile-build] Fehler 2
> dpkg-buildpackage: Fehler: Fehler-Exitstatus von debian/rules build war 2
> debuild: fatal error at line 1350:
> dpkg-buildpackage -rfakeroot -D -us -uc failed
> mike@sid:~/tmp/tigervnc.b$
> </quote>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPfyJqAAoJEIjUIAk+3OYMGEMP/jPKbrvb2cDpf9SGVDH2oCzE
s0iwm67XNKboWbrtRN9R3WqfxoSn6GTbvU7lwR2sgzd6gFpcJTd1yRjIGF32Y/St
kQ5hyCCrIbRUp8FUM8UGtBhn5rlyLRsb0qAmDDJO9nthgIP6gYKl1aj0IqW9iRF8
W8ZiO+dnqxrYJUhKMIx2zfAL5hl9/701xFnjSDUQkZHmjnICnFrODc6ABNB7Nly+
0dUs2KhDVRdDbitKMJJqrqKGj7OS1/+s5rooHPtopCzy+FW2P8KvQ/I5ulgaIMiR
6UflWJwan5ugJdF5hvsDJa9NnjjZmTlbmQc9s+leyYyGOzQAwwVn2WUVqUAtDFU2
dbksbWp+bt1MtsZa9YjmMm+9h1FT7//axJ9o33pdWnVB3b63u/c8oR39mbVbZqzh
/7CymZALvAY4Q28WCOVBDF+OEEeWdEk5t/rxpI+19auxriAHm8j8fsI+CzZYPvM7
SinAM2OxaJqsUhkZ7Mq1h/ToNIHobMzLSGdhvo4KFOaL3YQefvqg7ru+tcJ3zYl4
OiS1y79gDwQDw0EeDiYaCZ4fkyOv6Gh7M4pvNm44C2jPjuBB7nwG9RpltUN8fGAK
koO7DApod++H995p7net+8GhdlTzTwktmhvZJfhHGwaY+oNctrgWWsn3cWt+vnKh
YEFJ9sY+rBe75YTSjj7Z
=GSEL
-----END PGP SIGNATURE-----



Reply to: