On Wednesday 07 November 2012 07:09 PM, Timo Juhani Lindfors wrote: > I quickly browsed around a bit. The killall() function in > gateone/utils.py looks kind of scary. It seems to kill all processes > that contain python and gateone.py in their name. This should match > "emacs -nw python.txt gateone.py" and might be a mild security issue > too: > > for session in sessions: > if session in cmdline: > try: > os.kill(pid, signal.SIGTERM) > except OSError: > pass # PID is already dead--great > elif 'python' in cmdline: > if 'gateone.py' in cmdline: > try: > os.kill(pid, signal.SIGTERM) > except OSError: > pass # PID is already dead--great > > > Perhaps gateone could use cgroups? Thanks for spending time on it. I too came across it very recently. I liked the overall use case. But this definitely will go through some use, before it gets packaged. -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System
Attachment:
signature.asc
Description: OpenPGP digital signature