Bug#683746: rspamd packaging
Hi Vsevolod,
On Mon, 2012-08-06 at 16:30 +0400, Vsevolod Stakhov wrote:
> On 08/05/2012 10:46 AM, Laszlo Boszormenyi (GCS) wrote:
[ about the hardened build failure ]
> Well, I've tried the same on my ubuntu dev box and cannot repeat this
> issue. Can you please try it again with modified package?
Version 0.5.1 still fails with hardening enabled.
gcc is: gcc-4.7.real (Debian 4.7.1-5) 4.7.1
cmake is: cmake version 2.8.8
Related messages:
[ 10%] Building C object
lib/CMakeFiles/rspamd-util.dir/__/src/mem_pool.c.o
cd /root/compile/rspamd/rspamd-0.5.1/obj-x86_64-linux-gnu/lib && /usr/bin/cc -O0 -fstrict-aliasing -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DLINUX -fPIC -fpic -g -W -Wall -Wpointer-arith -Wno-unused-parameter -Wno-unused-function -Wunused-variable -Wno-pointer-sign -Wstrict-prototypes -pedantic -std=c99 -I/usr/include/x86_64-linux-gnu -I/usr/include/lua5.1 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gmime-2.6 -I/root/compile/rspamd/rspamd-0.5.1/compat -I/root/compile/rspamd/rspamd-0.5.1/src -I/root/compile/rspamd/rspamd-0.5.1/obj-x86_64-linux-gnu/src -I/root/compile/rspamd/rspamd-0.5.1/contrib/hiredis -I/root/compile/rspamd/rspamd-0.5.1/lib/src -fno-strict-aliasing -o CMakeFiles/rspamd-util.dir/__/src/mem_pool.c.o -c /root/compile/rspamd/rspamd-0.5.1/src/mem_pool.c
[...]
Linking C shared library libkvstorageclient.so
cd /root/compile/rspamd/rspamd-0.5.1/obj-x86_64-linux-gnu/lib && /usr/bin/cmake -E cmake_link_script CMakeFiles/kvstorageclient.dir/link.txt --verbose=1
/usr/bin/cc -fPIC -O0 -fstrict-aliasing -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DLINUX -fPIC -fpic -g -W -Wall -Wpointer-arith -Wno-unused-parameter -Wno-unused-function -Wunused-variable -Wno-pointer-sign -Wstrict-prototypes -pedantic -std=c99 -shared -Wl,-soname,libkvstorageclient.so -o libkvstorageclient.so CMakeFiles/kvstorageclient.dir/kvstorage/libkvstorageclient.c.o librspamd-util.a -lm -lrt -ldl -lutil -lpcre -lgmodule-2.0 -lrt -ldl -lutil -lpcre -lgmodule-2.0 -lglib-2.0 -lffi -levent
/usr/bin/ld.bfd.real: librspamd-util.a(mem_pool.c.o): relocation R_X86_64_PC32 against symbol `memory_pool_alloc' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld.bfd.real: final link failed: Bad value
collect2: error: ld returned 1 exit status
Where does memory_pool_alloc come from? Maybe its source is not compiled
with -fPIC / -fpic .
> I've fixed that as well. Thought FreeBSD port system is more tolerative
> in this aspect affording addition of the upstream changelog to a port's
> changelog, so why I thought that debian/changelog should be the same.
FreeBSD uses the port system, it needs to list upstream changes as
well. For us, the file is named _debian_/changelog .
On Tue, 2012-08-07 at 16:24 +0400, Vsevolod Stakhov wrote:
> On 08/06/2012 04:30 PM, Vsevolod Stakhov wrote:
> > Well, I've fixed all issues you pointed and committed them to rspamd
> > mercurial repository. I think I'll release 0.5.1 version soon and the
> > package would be for it, not for 0.5.0.
It seems there are still issues with debian/copyright . Please see the
attached patch.
> Well, I've released 0.5.1 version in which I've fixed all problems you
> pointed me out. So what should be my next steps - go to the
> mentors.debian.net and upload packages?
If you fix the mentioned bits, then please upload the package to
mentors.debian.net and notify me. I'm going to sponsor it.
Regards,
Laszlo/GCS
diff -Nur rspamd-0.5.1.orig/debian/copyright rspamd-0.5.1/debian/copyright
--- rspamd-0.5.1.orig/debian/copyright 2012-08-06 19:41:57.000000000 +0200
+++ rspamd-0.5.1/debian/copyright 2012-08-07 20:12:01.000000000 +0200
@@ -3,9 +3,9 @@
Source: https://bitbucket.org/vstakhov/rspamd
Files: contrib/lgpl/*
-Copyright: 1999, 2000 Scott Wimer
-Copyright: 2004, Matthias Clasen <mclasen@redhat.com>
-Copyright: 2005 - 2007, Marco Barisione <marco@barisione.org>
+Copyright: 1999, 2000 Scott Wimer,
+ 2004 Matthias Clasen <mclasen@redhat.com>,
+ 2005 - 2007 Marco Barisione <marco@barisione.org>
License: LGPL-2+
This program is free software; you can redistribute it
and/or modify it under the terms of the GNU Library General Public
@@ -51,9 +51,16 @@
Files: *
Copyright: 2008-2012 Vsevolod Stakhov <vsevolod@highsecure.ru>
-License: BSD
+License: BSD-2-Clause
Redistribution and use in source and binary forms, with or without
- modification, are permitted under the terms of the BSD License.
+ modification, are permitted provided that the following conditions are met:
+ .
+ Redistributions of source code must retain the above copyright notice, this
+ list of conditions and the following disclaimer.
+ .
+ Redistributions in binary form must reproduce the above copyright notice,
+ this list of conditions and the following disclaimer in the documentation
+ and/or other materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
@@ -66,9 +73,6 @@
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
- .
- On Debian systems, the complete text of the BSD License can be
- found in `/usr/share/common-licenses/BSD'.
Files: debian/*
Copyright: 2011-2012 Vsevolod Stakhov <vsevolod@highsecure.ru>
Reply to: