Bug#670062: fofix in debian
I decided to play again with fofix after a long break (2 years ?), and to my surprise, it doesn't work anymore in testing !
Actually there are a few problems :
- in the default installation, with the no_numeric_module patch applied, you can't hear what you are playing (the active track). Actually this patch is not even useful anymore, now pygame is at version 1.9.1 so it will always use numpy. And if you enable the log, you'll notice that it says "zeros is not defined", and zeros is the function affected by this patch. I don't even understand why it's not defined, normally the numpy version should be defined. Anyway, uncommenting the patch makes everything to work as intended, the numpy version of zeros is enabled again, and then you get a nice crash as soon as you try to play something ! (you get the same thing if you take the fofix package directly from the fofix site, without any debian patch).
- So the 2nd problem is in pyvorbis this time. The author of the module tried to override the prototype for the callback to ov_read, and it's an extremely bad idea. For some reason, it worked before, maybe something has changed in the way parameters are passed in the libc, but what is sure is that it doesn't work anymore. I attach a patch to fix that to this mail. As it is currently the arguments of read are just ignored, but fofix doesn't use them and I doubt any program would want to use them anyway.
(these problems are reproducable with both python 2.7 and 2.6).
And since I tried to use this on a tv, using an interface to run it with the -geometry command line argument to avoid the tv borders, I attach a 2nd patch to add the -geometry command line argument ! This one doesn't fix anything, it's just more convenient.
I have read the current maintainer wants to give up this package, that's bad news...
By the way it has also a very bad bug about memory management, if you use a big graphical theme with it, the bug becomes really obvious, with such a theme it can eat as much as 150-200 Mb between songs ! But this one is in the native fofix package and related to circular references in objects apparently, so very hard to fix.
Well I hope these patches will be useful anyway !
Attachment:
pyvorbisfile-diff
Description: Binary data
Attachment:
0001-geometry-command-line-argument.patch
Description: Binary data
Reply to: