Bug#602126: Package ready

[Michael Banck <mbanck@debian.org>]

Hi,

On Thu, May 24, 2012 at 12:30:27AM +0200, Ask Hjorth Larsen wrote:
> 2012/5/23 Michael Banck <mbanck@debian.org>:
> On Mon, May 21, 2012 at 04:28:55PM +0200, Ask Hjorth Larsen wrote:
>> We have a package now which is ready to be uploaded. Â So we would like
>> to have this bug promoted to an RFS.
>
> Great news!
>
> If you point me to a source package, I can review it and upload.

This tarball contains the source directory plus the various source
package files.

  http://www.student.dtu.dk/~ashj/opendir/python-ase-3.6.0.2515-debian.tar.gz

I took a look at it now.

I think the following issues need to be resolved first:

1. The changelog entry should not refer to ppa, and should read
"unstable" as distribution.  If the package was never in Ubuntu, I would
also suggest to remove all prior changelog entries and just have one
entry saying "Initial upload (Closes: #602126)." or so.

2. The copyright information seems to be incomplete, a quick recursive
grep for "Copyright" in the ase/ directory yields at least CAMP, Jesper
Friis and Neil Martinsen-Burrell as additional copyright holders.

3. io/fortranfile.py also has a BSD-like license which must be added to
copyright.  Possibly other files have different copyright as well, I
have not checked them all.

Those are suggestions and not required for upload:

1. It might be a good idea to run testase on package build as well, e.g.
to catch possible issues with different architectures (a long shot I
guess, as it seems to be all-python)

2. If you want to maintain ASE as part of debichem, you should set
"Debichem Team <debichem-devel@lists.alioth.debian.org>" as Maintainer
in debian/control and set yourself as Uploaders:

3. The patch "debian-changes-3.6.0.2515-1~ppa3" in debian/patches should
get split up into logical parts with descriptive file names each.
However, if the next upstream version has this patch anyway, it might
not be worth the effort.

4. If all the changes mentioned in README.Debian are in the above patch,
you do not need to mention them there and can delete the file



Cheers,

Michael