Hi, thank you for the review. On 01/03/2012 01:31 PM, Aron Xu wrote: > 1.I'm wondering whether we should enable GTK+ 3 support for all the > packages, which has been requested[1]. I enabled the GTK+ 3 support in gmtk. > 2.You have disabled the generation of static library, which I'm > curious about the reason. You can safely ship those > files in -dev packages. I've lost the the static library in the install files while converting the package to multiarch and wondered afterwards why we built with support for the static library. That's why I disabled it. I re-enabled the static libraries. > 3.For symbols that should be private, it would be okay to patch the > build system to add a library version script, > so you can control which symbols are exported without touching many > source files. I'll have a look at it. > 4. It would be better not to override > package-needs-versioned-debhelper-build-depends, so it can remind us > to update Build-Dep > field when debhelper 9 is out. Okay, I removed debian/source.linitian.override. Kind regards, -- Sebastian Ramacher
Attachment:
signature.asc
Description: OpenPGP digital signature