Hi Andrew,
Le dimanche 13 févr. 2011 à 22:26:28 (+0100 CET), Andrew Gainer a écrit :
> I have prepared (what I believe is) a compliant Debian package for
> volumeicon and am in the process of finding a sponsor.
I have quickly checked the package available on mentors.d.n and while it
is mostly ok, there are still a few things to improve:
* You have made direct changes to the upstream source code, leading to the
creation of a debian-changes-0.3.0-2 patch
* You don't need to depend on libgtk2.0-0 (the dependency is automatically
added by dpkg-shlibdeps)
* For a first upload to Debian, please keep the changelog clean and make
sure the ITP gets closed
* dpkg-shlideps warns about the binary to be linked against several unused
libraries - you might want to build the package using -Wl,--as-needed
* You should specify the GPL-3 license text in a standalone license
paragraph as recommended in DEP-5
* You miss several copyright information (mostly for autotools files etc.)
* You ship an empty NEWS file in the package, as well as a useless README
(which only contains information on how to build volumeicon) - AUTHORS
is imho also useless as the information is also in the copyright file
* Have you forwarded your manpage to the upstream developer?
I'd be happy to upload this package for you if you fix these points (or
argue why you won't fix some of them).
You can contact me directly, either by mail or on IRC (as jvalroff on
freenode and oftc).
Cheers,
Julien
--
.''`. Julien Valroff ~ <julien@kirya.net> ~ <julien@debian.org>
: :' : Debian Developer & Free software contributor
`. `'` http://www.kirya.net/
`- 4096R/ E1D8 5796 8214 4687 E416 948C 859F EF67 258E 26B1
Attachment:
signature.asc
Description: Digital signature